From: Michal Marek <mmarek@suse.com>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ia64@vger.kernel.org, xen-devel@lists.xenproject.org,
linux-acpi@vger.kernel.org, rds-devel@oss.oracle.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros
Date: Thu, 22 Oct 2015 14:24:14 +0200 [thread overview]
Message-ID: <5628D56E.9080206@suse.com> (raw)
In-Reply-To: <5628D332.9030304@redhat.com>
On 2015-10-22 14:14, Prarit Bhargava wrote:
> On 10/22/2015 08:06 AM, Michal Marek wrote:
>> It used to require a closing parenthesis, so it would not match the
>> multiline macro invocations at all. Now it matches them, but ctags
>> correctly warns that the empty string is probably not what we intended
>> to match.
>
> It seems wrong to change kernel code, not for a bug, but for a userspace search.
The bug is that the code cannot be indexed using ctags or etags.
Michal
prev parent reply other threads:[~2015-10-22 12:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1444940195-28272-1-git-send-email-mmarek@suse.com>
2015-10-15 20:16 ` [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros Michal Marek
2015-10-21 19:27 ` Prarit Bhargava
2015-10-21 19:52 ` Michal Marek
2015-10-22 11:31 ` Prarit Bhargava
2015-10-22 12:06 ` Michal Marek
2015-10-22 12:14 ` Prarit Bhargava
2015-10-22 12:24 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5628D56E.9080206@suse.com \
--to=mmarek@suse.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=rds-devel@oss.oracle.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).