linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Timur Tabi <timur@codeaurora.org>
To: okaya@codeaurora.org, Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	cov@codeaurora.org, jcm@redhat.com,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] acpi: add support for extended IRQ to PCI link
Date: Thu, 12 Nov 2015 09:58:15 -0600	[thread overview]
Message-ID: <5644B717.5070707@codeaurora.org> (raw)
In-Reply-To: <0ef6f6fb8bdce49101ec60ca464f9118.squirrel@www.codeaurora.org>

okaya@codeaurora.org wrote:
> This is what it was before.
>
>> >         if (acpi_irq_balance || !link->irq.active) {
>> >-               /*
>> >-                * Select the best IRQ.  This is done in reverse to promote
>> >-                * the use of IRQs 9, 10, 11, and >15.
>> >-                */
>> >-               for (i = (link->irq.possible_count - 1); i >= 0; i--) {
>> >-                       if (acpi_irq_penalty[irq] >
>> >-                           acpi_irq_penalty[link->irq.possible[i]])
>> >-                               irq = link->irq.possible[i];
> I added a range check for link->irq.possible[i] and irq into this code.
>
>

This change:

-	 * Select the best IRQ.  This is done in reverse to promote
-	 * the use of IRQs 9, 10, 11, and >15.
+	 * Select the best IRQ.  This is done in reverse to
+	 * promote the use of IRQs 9, 10, 11, and >15.

is an unrelated whitespace change.  It doesn't belong in this patch.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.

  reply	other threads:[~2015-11-12 15:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-12  6:14 [PATCH V2] acpi: add support for extended IRQ to PCI link Sinan Kaya
2015-11-12  6:14 ` [PATCH] " Sinan Kaya
2015-11-12  9:56   ` Andy Shevchenko
2015-11-12 15:04     ` Sinan Kaya
2015-11-12 15:17       ` Andy Shevchenko
2015-11-12 15:54         ` okaya
2015-11-12 15:58           ` Timur Tabi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-11-08 16:07 Sinan Kaya
2015-11-08 16:11 ` Timur Tabi
2015-11-09  0:04   ` Sinan Kaya
2015-11-09  0:05     ` Timur Tabi
2015-11-09 21:49       ` Rafael J. Wysocki
2015-11-08 20:35 ` Andy Shevchenko
2015-11-09 22:29   ` Sinan Kaya
2015-11-09  5:24 ` Jiang Liu
2015-11-09  5:45   ` Sinan Kaya
2015-11-09  8:45     ` Jiang Liu
2015-11-09 13:50     ` Timur Tabi
2015-11-09 16:28       ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5644B717.5070707@codeaurora.org \
    --to=timur@codeaurora.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=cov@codeaurora.org \
    --cc=jcm@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=okaya@codeaurora.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).