From: "Yankejian (Hackim Yim)" <yankejian@huawei.com>
To: Al Stone <ahs3@redhat.com>, Graeme Gregory <gg@slimlogic.co.uk>
Cc: rjw@rjwysocki.net, lenb@kernel.org, davem@davemloft.net,
liguozhu@huawei.com, yisen.zhuang@huawei.com,
huangdaode@hisilicon.com, lipeng321@huawei.com,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linuxarm@huawei.com
Subject: Re: [PATCH] ACPI: Add phylib support code for mdio
Date: Wed, 9 Dec 2015 18:31:12 +0800 [thread overview]
Message-ID: <566802F0.2020103@huawei.com> (raw)
In-Reply-To: <566735CF.30000@redhat.com>
On 2015/12/9 3:55, Al Stone wrote:
> On 12/03/2015 03:47 AM, Graeme Gregory wrote:
>> On Thu, Dec 03, 2015 at 09:54:43AM +0800, yankejian wrote:
>>> Add support for getting the PHY devices on an MDIO bus by ACPI.
>>> Currently many of the ethernet drivers are open coding a solution
>>> for reading data out of ACPI to find the correct PHY device.
>>> This patch implements a set of common routines are similar to of_mdio.c
>>>
>> The general conclusion for the ACPI on ARM64 discussion so far has been that
>> things like PHYs should be setup by the firmware before the kernel takes
>> control.
>>
>> I am unsure that this doing it the same way as DT with a different
>> description language is the way to go.
>>
>> Graeme
> I have to agree with Graeme: if this is supposed to be an arm64 server using
> ACPI, please make sure the PHYs/clocks/regulators are set up properly before
> passing control to the kernel. That's the consensus so far on how this is to
> be done.
>
> This also looks to be using _DSD in ACPI, which is another topic that's still
> under discussion. What does the ASL look like for these PHYs, as used in this
> patch?
>
Hi Al
The sample of the ASL for these PHYs is below:
Device (PHY0) {
Name (_DSD, Package () {
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package () {
Package () {"phy-addr", 0},
Package () {"ethernet-phy", "ethernet-phy-ieee802.3-c22"},
}
})
}
Best Regards,
yankejian
next prev parent reply other threads:[~2015-12-09 10:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 1:54 [PATCH] ACPI: Add phylib support code for mdio yankejian
2015-12-03 4:45 ` kbuild test robot
2015-12-03 4:55 ` kbuild test robot
2015-12-03 10:47 ` Graeme Gregory
2015-12-08 19:55 ` Al Stone
2015-12-09 10:31 ` Yankejian (Hackim Yim) [this message]
2015-12-10 1:27 ` Yankejian (Hackim Yim)
2016-01-12 12:12 ` Yankejian (Hackim Yim)
2016-01-12 12:39 ` Graeme Gregory
2016-01-13 3:03 ` Yankejian (Hackim Yim)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566802F0.2020103@huawei.com \
--to=yankejian@huawei.com \
--cc=ahs3@redhat.com \
--cc=davem@davemloft.net \
--cc=gg@slimlogic.co.uk \
--cc=huangdaode@hisilicon.com \
--cc=lenb@kernel.org \
--cc=liguozhu@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=rjw@rjwysocki.net \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).