From: Al Stone <ahs3@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v1 1/1] ACPI / LPSS: change 'does not' to 'does' in comment
Date: Mon, 21 Dec 2015 10:59:07 -0700 [thread overview]
Message-ID: <56783DEB.7040304@redhat.com> (raw)
In-Reply-To: <1450720245-67575-1-git-send-email-andriy.shevchenko@linux.intel.com>
On 12/21/2015 10:50 AM, Andy Shevchenko wrote:
> The LPSS DMA device does have neither _PS0 nor _PS3 method. Fix the wording in
> the comment line.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/acpi/acpi_lpss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
> index 84d3d90..6c6661d 100644
> --- a/drivers/acpi/acpi_lpss.c
> +++ b/drivers/acpi/acpi_lpss.c
> @@ -95,7 +95,7 @@ static unsigned int lpss_quirks;
> /*
> * LPSS_QUIRK_ALWAYS_POWER_ON: override power state for LPSS DMA device.
> *
> - * The LPSS DMA controller does not have neither _PS0 nor _PS3 method. Moreover
> + * The LPSS DMA controller does have neither _PS0 nor _PS3 method. Moreover
Neither of the above are very clear. I think proper English would be:
The LPSS DMA controller has neither a _PS0 nor a _PS3 method.
or, alternatively:
The LPSS DMA controller does not have either a _PS0 or a _PS3 method.
This assumes that the point of the statement is to say that _PS0 and _PS3
methods do not exist for the LPSS DMA controller.
> * it can be powered off automatically whenever the last LPSS device goes down.
> * In case of no power any access to the DMA controller will hang the system.
> * The behaviour is reproduced on some HP laptops based on Intel BayTrail as
>
--
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Red Hat, Inc.
ahs3@redhat.com
-----------------------------------
next prev parent reply other threads:[~2015-12-21 17:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 17:50 [PATCH v1 1/1] ACPI / LPSS: change 'does not' to 'does' in comment Andy Shevchenko
2015-12-21 17:59 ` Al Stone [this message]
2015-12-21 19:09 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56783DEB.7040304@redhat.com \
--to=ahs3@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).