From: Timur Tabi <timur@codeaurora.org>
To: Ashwin Chaugule <ashwin.chaugule@linaro.org>
Cc: Prashanth Prakash <pprakash@codeaurora.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux acpi <linux-acpi@vger.kernel.org>,
Linaro ACPI Mailman List <linaro-acpi@lists.linaro.org>
Subject: Re: [Linaro-acpi] [PATCH V2 3/4] mailbox: pcc: optimized pcc_send_data
Date: Mon, 25 Jan 2016 12:52:17 -0600 [thread overview]
Message-ID: <56A66EE1.6010605@codeaurora.org> (raw)
In-Reply-To: <CAJ5Y-eYtTz05Vk+DOLhKk8gOMo5j7x_DAqZmvQRC4kW40XPsfQ@mail.gmail.com>
Ashwin Chaugule wrote:
>>> + pcc_doorbell_vaddr = kcalloc(count, sizeof(void *), GFP_KERNEL);
>>
>> ... this is wrong. You're using readl() and writel() on this pointer,
>> but it's not an iomem pointer, it's normal kernel memory. You need to
>> delete your usage of readX, writeX on this pointer.
>>
>
> The acpi_os_ioremap() below should take care of that.
...
>>> + if (db_reg->space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY)
>>> + pcc_doorbell_vaddr[i] = acpi_os_ioremap(db_reg->address,
>>> + db_reg->bit_width/8);
Ah, I see. pcc_doorbell_vaddr[i] still needs to be an __iomem*, and the
rest of the code needs to honor that.
next prev parent reply other threads:[~2016-01-25 18:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 1:07 [PATCH V2 0/4] acpi: cppc optimization patches Prashanth Prakash
2016-01-23 1:07 ` [PATCH V2 1/4] ACPI / CPPC: Optimize PCC Read Write operations Prashanth Prakash
2016-01-25 17:19 ` [Linaro-acpi] " Timur Tabi
2016-01-25 20:26 ` Ashwin Chaugule
2016-01-25 20:48 ` Timur Tabi
2016-01-26 16:41 ` Prakash, Prashanth
2016-02-01 19:38 ` Alexey Klimov
2016-02-01 21:06 ` Prakash, Prashanth
2016-01-23 1:07 ` [PATCH V2 2/4] acpi: cppc: optimized cpc_read and cpc_write Prashanth Prakash
2016-01-25 17:22 ` [Linaro-acpi] " Timur Tabi
2016-01-23 1:07 ` [PATCH V2 3/4] mailbox: pcc: optimized pcc_send_data Prashanth Prakash
2016-01-25 17:34 ` [Linaro-acpi] " Timur Tabi
2016-01-25 18:26 ` Ashwin Chaugule
2016-01-25 18:52 ` Timur Tabi [this message]
2016-01-23 1:07 ` [PATCH V2 4/4] acpi: cppc: replace writeX/readX to PCC with relaxed version Prashanth Prakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A66EE1.6010605@codeaurora.org \
--to=timur@codeaurora.org \
--cc=ashwin.chaugule@linaro.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=pprakash@codeaurora.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).