linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Prakash, Prashanth" <pprakash@codeaurora.org>
To: Timur Tabi <timur@codeaurora.org>,
	Ashwin Chaugule <ashwin.chaugule@linaro.org>
Cc: linux acpi <linux-acpi@vger.kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linaro ACPI Mailman List <linaro-acpi@lists.linaro.org>
Subject: Re: [Linaro-acpi] [PATCH V2 1/4] ACPI / CPPC: Optimize PCC Read Write operations
Date: Tue, 26 Jan 2016 09:41:27 -0700	[thread overview]
Message-ID: <56A7A1B7.30808@codeaurora.org> (raw)
In-Reply-To: <56A68A03.4090101@codeaurora.org>

Hi Ashwin/Timur,
>> Unless Rafael thinks otherwise, I see no major issues in V2, so there
>> is no need for a respin.
>
> I think stripping away the __iomem is wrong.  The whole point behind the 'sparse' tool is to catch invalid accesses to I/O memory.  When you typecast it away, then prevent sparse from catching those problem.

Thanks for your inputs. I will wait for few more days for feedback from Rafael and others before another respin with the suggested changes.

Thanks,
Prashanth

  reply	other threads:[~2016-01-26 16:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-23  1:07 [PATCH V2 0/4] acpi: cppc optimization patches Prashanth Prakash
2016-01-23  1:07 ` [PATCH V2 1/4] ACPI / CPPC: Optimize PCC Read Write operations Prashanth Prakash
2016-01-25 17:19   ` [Linaro-acpi] " Timur Tabi
2016-01-25 20:26     ` Ashwin Chaugule
2016-01-25 20:48       ` Timur Tabi
2016-01-26 16:41         ` Prakash, Prashanth [this message]
2016-02-01 19:38   ` Alexey Klimov
2016-02-01 21:06     ` Prakash, Prashanth
2016-01-23  1:07 ` [PATCH V2 2/4] acpi: cppc: optimized cpc_read and cpc_write Prashanth Prakash
2016-01-25 17:22   ` [Linaro-acpi] " Timur Tabi
2016-01-23  1:07 ` [PATCH V2 3/4] mailbox: pcc: optimized pcc_send_data Prashanth Prakash
2016-01-25 17:34   ` [Linaro-acpi] " Timur Tabi
2016-01-25 18:26     ` Ashwin Chaugule
2016-01-25 18:52       ` Timur Tabi
2016-01-23  1:07 ` [PATCH V2 4/4] acpi: cppc: replace writeX/readX to PCC with relaxed version Prashanth Prakash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A7A1B7.30808@codeaurora.org \
    --to=pprakash@codeaurora.org \
    --cc=ashwin.chaugule@linaro.org \
    --cc=linaro-acpi@lists.linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).