From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: fu.wei@linaro.org, rjw@rjwysocki.net, lenb@kernel.org,
tglx@linutronix.de, marc.zyngier@arm.com, hanjun.guo@linaro.org
Cc: linux-arm-kernel@lists.infradead.org,
linaro-acpi@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, rruigrok@codeaurora.org,
harba@codeaurora.org, cov@codeaurora.org, timur@codeaurora.org,
graeme.gregory@linaro.org, al.stone@linaro.org, jcm@redhat.com,
wei@redhat.com, arnd@arndb.de, wim@iguana.be,
catalin.marinas@arm.com, will.deacon@arm.com,
Suravee.Suthikulpanit@amd.com, leo.duran@amd.com
Subject: Re: [RESEND PATCH v4 0/5] acpi, clocksource: add GTDT and ARM memory-mapped timer support
Date: Fri, 18 Mar 2016 14:37:41 +0100 [thread overview]
Message-ID: <56EC04A5.2030106@linaro.org> (raw)
In-Reply-To: <1458288053-29031-1-git-send-email-fu.wei@linaro.org>
On 03/18/2016 09:00 AM, fu.wei@linaro.org wrote:
> From: Fu Wei <fu.wei@linaro.org>
>
> This patchset:
> (1)Move some enums and marcos to header file for arm_arch_timer,
> improve the pr_* code by defining "pr_fmt(fmt)" in arm_arch_timer.c
>
> (2)Introduce ACPI GTDT parser: drivers/acpi/gtdt.c
> Parse all kinds of timer in GTDT table of ACPI:arch timer,
> memory-mapped timer and SBSA Generic Watchdog timer.
> This driver can help to simplify all the relevant timer drivers,
> and separate all the ACPI GTDT knowledge from them.
>
> (3)Simplify ACPI code for arch timer in arm_arch_timer.c
>
> (4)Add memory-mapped timer support in arm_arch_timer.c
>
> RESEND:
> -- Corrected Cc list: added missing mailing lists
Hi Fu Wei,
the whole series is lacking to encapsulate the ACPI code.
I believe Marc Zyngier did a first effort to make the ACPI self
contained and this series ignore that.
Please rework the series in the direction no acpi gtdt structure appears
in the driver.
Thanks
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-03-18 13:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 8:00 [RESEND PATCH v4 0/5] acpi, clocksource: add GTDT and ARM memory-mapped timer support fu.wei
2016-03-18 8:00 ` [RESEND PATCH v4 1/5] clocksource: move some enums and marcos to header file for arm_arch_timer fu.wei
2016-03-18 9:27 ` Thomas Gleixner
2016-03-29 9:38 ` Fu Wei
2016-03-18 8:00 ` [RESEND PATCH v4 2/5] ACPI: add GTDT table parse driver into ACPI driver fu.wei
2016-03-18 14:45 ` Daniel Lezcano
2016-03-18 8:00 ` [RESEND PATCH v4 3/5] clocksource: simplify ACPI code in arm_arch_timer.c fu.wei
2016-03-18 8:00 ` [RESEND PATCH v4 4/5] clocksource: a little improvment for printk " fu.wei
2016-03-18 8:00 ` [RESEND PATCH v4 5/5] clocksource: add memory-mapped timer support " fu.wei
2016-03-18 9:32 ` Thomas Gleixner
2016-03-18 13:37 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EC04A5.2030106@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=al.stone@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=cov@codeaurora.org \
--cc=fu.wei@linaro.org \
--cc=graeme.gregory@linaro.org \
--cc=hanjun.guo@linaro.org \
--cc=harba@codeaurora.org \
--cc=jcm@redhat.com \
--cc=lenb@kernel.org \
--cc=leo.duran@amd.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rjw@rjwysocki.net \
--cc=rruigrok@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
--cc=wei@redhat.com \
--cc=will.deacon@arm.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).