From: Tony <tony.makkiel@daqri.com>
To: Jacek Anaszewski <j.anaszewski@samsung.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-leds@vger.kernel.org, rpurdie@rpsys.net, lenb@kernel.org,
mika.westerberg@linux.intel.com, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v7 1/1] leds: LED driver for TI LP3952 6-Channel Color LED
Date: Wed, 29 Jun 2016 11:07:10 +0100 [thread overview]
Message-ID: <57739DCE.3030303@daqri.com> (raw)
In-Reply-To: <57737021.1010603@samsung.com>
On 29/06/16 07:52, Jacek Anaszewski wrote:
> Hi Rafael,
>>> +#ifdef CONFIG_ACPI
>>> +static const struct acpi_device_id lp3952_acpi_match[] = {
>>> + {LP3952_ACPI_NAME, 0},
>>
>> No, you can't use "PRP0001" in this list.
>>
>>> + {}
>>> +};
>>> +
>>> +MODULE_DEVICE_TABLE(acpi, lp3952_acpi_match);
>>
>> And you don't need this for the "PRP0001" thing to work. The core will
>> take care of it for you then.
>>
>>> +#endif
>>
>> So the entire ACPI block can be dropped for now.
>>
>> And the driver doesn't have to depend on CONFIG_ACPI any more, does it?
>
> The driver currently supports probing only with ACPI.
> I have one question BTW: isn't there anything similar to the device tree
> bindings documentation required for ACPI overlays?
> Pointer to the discussion which led us to this solution:
>
> http://www.spinics.net/lists/linux-leds/msg06230.html
>
_DSD is working now. I managed to get "PRP0001" working as suggested by
Rafael in
http://marc.info/?l=linux-acpi&m=146711623115228&w=2
with _DSD
I will try adding names using _DSD. I am not sure why DSD didn't work
earlier. The only reason I could think of is, upgrading my OS recently
following a raid failure.
>
>>>
next prev parent reply other threads:[~2016-06-29 10:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 16:05 [PATCH v7 1/1] leds: LED driver for TI LP3952 6-Channel Color LED Tony Makkiel
2016-06-29 0:45 ` Rafael J. Wysocki
2016-06-29 6:52 ` Jacek Anaszewski
2016-06-29 10:07 ` Tony [this message]
2016-06-29 10:54 ` Jacek Anaszewski
2016-07-05 10:47 ` Jacek Anaszewski
2016-07-05 12:12 ` Rafael J. Wysocki
2016-07-05 12:33 ` Jacek Anaszewski
2016-07-05 13:14 ` Tony
2016-07-06 13:32 ` Jacek Anaszewski
2016-07-06 21:15 ` Rafael J. Wysocki
2016-07-07 7:13 ` Jacek Anaszewski
2016-07-07 10:35 ` Tony
2016-07-07 11:09 ` Jacek Anaszewski
2016-06-29 10:02 ` Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57739DCE.3030303@daqri.com \
--to=tony.makkiel@daqri.com \
--cc=j.anaszewski@samsung.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).