From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH] acpi, nfit: fix acpi_check_dsm() vs zero functions implemented Date: Thu, 21 Jul 2016 13:40:00 +0800 Message-ID: <57906030.4010701@linux.intel.com> References: <146679026571.24395.11569929364936343871.stgit@dwillia2-desk3.amr.corp.intel.com> <20160719171153.GA121461@tevye.fc.hp.com> <20160719224644.GJ140413@tevye.fc.hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com ([134.134.136.65]:20447 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbcGUFoO (ORCPT ); Thu, 21 Jul 2016 01:44:14 -0400 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Dan Williams , Jerry Hoemann Cc: Linda Knippers , "linux-nvdimm@lists.01.org" , "Rafael J. Wysocki" , Linux ACPI , Len Brown , Marvin Spinhirne On 07/21/2016 06:49 AM, Dan Williams wrote: > On Tue, Jul 19, 2016 at 3:53 PM, Dan Williams wrote: >> On Tue, Jul 19, 2016 at 3:46 PM, Jerry Hoemann wrote: >>> On Tue, Jul 19, 2016 at 01:01:16PM -0700, Dan Williams wrote: >>>> On Tue, Jul 19, 2016 at 11:52 AM, Dan Williams wrote: >>>>> On Tue, Jul 19, 2016 at 11:50 AM, Linda Knippers wrote: >>>>>> On 7/19/2016 1:11 PM, Jerry Hoemann wrote: >>>> [..] >>>>>>> As nfit_mem->family always equals NVDIMM_FAMILY_INTEL, no subsequent >>>>>>> DSM call will succeed for NVDIMM_FAMILY_HPE1 or any other >>>>>>> family. >>>>>>> >>>>>>> I don't have a fix as of yet, but wanted to make you aware of >>>>>>> the problem. >>>>>> >>>>>> Could we try the all known UUIDs looking for one that returns a non-zero >>>>>> value? >>>>>> >>>>> >>>>> Yes, that seems like the way forward, and also make not finding a DSM >>>>> family non-fatal. >>>> >>>> Actually, all we need is that last bit... Jerry, Xiao, can you try >>>> the attached patch on top for v4.7-rc6 to see if it works in both HPe >>>> and QEMU 2.6 environments respectively? >>> >>> Dan, >>> >>> I applied this patch on top of the SLES 12 sp2 kernel I was testing >>> with last night. >>> >>> The proposed patch below works for HPE nvdimms. >> >> Thanks Jerry, I'll add your Tested-by and push it for v4.7-final after >> Xiao has a chance to confirm. > > I was able to verify this on QEMU 2.6. > Thank you, Dan. :)