From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Covington Subject: Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support Date: Tue, 26 Jul 2016 09:19:15 -0400 Message-ID: <57976353.7080500@codeaurora.org> References: <1466420541-20101-2-git-send-email-tn@semihalf.com> <1466598909-27504-1-git-send-email-tn@semihalf.com> <576A91CC.3000101@arm.com> <576A9824.1060400@semihalf.com> <576AA603.3080505@arm.com> <576B3CBD.60309@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:44121 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754569AbcGZNTX (ORCPT ); Tue, 26 Jul 2016 09:19:23 -0400 In-Reply-To: <576B3CBD.60309@huawei.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Marc Zyngier Cc: Hanjun Guo , Tomasz Nowicki , tglx@linutronix.de, jason@lakedaemon.net, rjw@rjwysocki.net, bhelgaas@google.com, lorenzo.pieralisi@arm.com, robert.richter@caviumnetworks.com, shijie.huang@arm.com, Suravee.Suthikulpanit@amd.com, hanjun.guo@linaro.org, al.stone@linaro.org, mw@semihalf.com, graeme.gregory@linaro.org, Catalin.Marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ddaney.cavm@gmail.com, okaya@codeaurora.org, andrea.gallo@linaro.org, linux-pci@vger.kernel.org Hi Marc, On 06/22/2016 09:34 PM, Hanjun Guo wrote: > On 2016/6/22 22:51, Marc Zyngier wrote: >> On 22/06/16 14:52, Tomasz Nowicki wrote: >>> On 22.06.2016 15:25, Marc Zyngier wrote: >>>> On 22/06/16 13:35, Tomasz Nowicki wrote: >>>>> IORT shows representation of IO topology for ARM based systems. >>>>> It describes how various components are connected together on >>>>> parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec. >>>>> http://infocenter.arm.com/help/topic/com.arm.doc.den0049b/DEN0049B_IO_Remapping_Table.pdf >>>>> >>>>> Initial support allows to detect IORT table presence and save its >>>>> root pointer obtained through acpi_get_table(). The pointer validity >>>>> depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap >>>>> is not set while using IORT nodes we would dereference unmapped pointers. >>>>> >>>>> For the aforementioned reason call iort_table_detect() from acpi_init() >>>>> which guarantees acpi_gbl_permanent_mmap to be set at that point. >>>>> >>>>> Add generic helpers which are helpful for scanning and retrieving >>>>> information from IORT table content. List of the most important helpers: >>>>> - iort_find_dev_node() finds IORT node for a given device >>>>> - iort_node_map_rid() maps device RID and returns IORT node which provides >>>>> final translation >>>>> >>>>> Signed-off-by: Tomasz Nowicki >>>>> --- >>>>> drivers/acpi/Kconfig | 3 + >>>>> drivers/acpi/Makefile | 1 + >>>>> drivers/acpi/bus.c | 2 + >>>>> drivers/acpi/iort.c | 217 ++++++++++++++++++++++++++++++++++++++++++++++++++ >>>>> include/linux/iort.h | 30 +++++++ >>>>> 5 files changed, 253 insertions(+) >>>>> create mode 100644 drivers/acpi/iort.c >>>>> create mode 100644 include/linux/iort.h > I tracked Marc's tree on git.kernel.org, it's acpi_os_free(buffer.pointer) there so > my worry is gone :) Do you plan on submitting this during the 4.8 merge window? Thanks, Cov -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.