From mboxrd@z Thu Jan 1 00:00:00 1970 From: "majun (Euler7)" Subject: Re: [PATCH] ACPI: fix the process flow for 0 which return from acpi_register_gsi Date: Thu, 1 Dec 2016 15:43:55 +0800 Message-ID: <583FD4BB.6060807@huawei.com> References: <1480578107-12512-1-git-send-email-majun258@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="gbk" Content-Transfer-Encoding: 8bit Return-path: Received: from szxga01-in.huawei.com ([58.251.152.64]:13665 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757487AbcLAHoQ (ORCPT ); Thu, 1 Dec 2016 02:44:16 -0500 In-Reply-To: <1480578107-12512-1-git-send-email-majun258@huawei.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: linux-kernel@vger.kernel.org, marc.zyngier@arm.com, linux-acpi@vger.kernel.org, robert.moore@intel.com, lenb@kernel.org, lv.zheng@intel.com, rafael.j.wysocki@intel.com, devel@acpica.org, mark.rutland@arm.com, robh+dt@kernel.org, jason@lakedaemon.net Cc: majun258@huawei.com, dingtianhong@huawei.com, guohanjun@huawei.com sorry, ignore this one.. ÔÚ 2016/12/1 15:41, Majun дµÀ: > From: MaJun > > The return value 0 from acpi_register_gsi() means irq mapping failed. > So, we should process this case in else branch. > > Signed-off-by: MaJun > --- > drivers/acpi/resource.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c > index 56241eb..9918326 100644 > --- a/drivers/acpi/resource.c > +++ b/drivers/acpi/resource.c > @@ -416,7 +416,7 @@ static void acpi_dev_get_irqresource(struct resource *res, u32 gsi, > > res->flags = acpi_dev_irq_flags(triggering, polarity, shareable); > irq = acpi_register_gsi(NULL, gsi, triggering, polarity); > - if (irq >= 0) { > + if (irq > 0) { > res->start = irq; > res->end = irq; > } else { >