From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Subject: Re: [PATCH v2] acpi/arm64: pr_err() strings should end with newlines Date: Tue, 10 Oct 2017 17:33:50 +0800 Message-ID: <59DC93FE.2060004@huawei.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Arvind Yadav , lorenzo.pieralisi@arm.com, hanjun.guo@linaro.org, sudeep.holla@arm.com, rjw@rjwysocki.net, lenb@kernel.org Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On 2017/9/25 15:24, Arvind Yadav wrote: > pr_err() messages should terminated with a new-line to avoid > other messages being concatenated onto the end. > > Signed-off-by: Arvind Yadav > --- > changes in v2: > Add changelog. > > drivers/acpi/arm64/gtdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c > index 597a737..92f9edf 100644 > --- a/drivers/acpi/arm64/gtdt.c > +++ b/drivers/acpi/arm64/gtdt.c > @@ -199,7 +199,7 @@ static int __init gtdt_parse_timer_block(struct acpi_gtdt_timer_block *block, > struct acpi_gtdt_timer_entry *gtdt_frame; > > if (!block->timer_count) { > - pr_err(FW_BUG "GT block present, but frame count is zero."); > + pr_err(FW_BUG "GT block present, but frame count is zero.\n"); > return -ENODEV; > } > Make sense to me, Acked-by: Hanjun Guo Lorenzo, could you pick this up for 4.15? Thanks Hanjun