Re: [PATCH 1/3] ACPI / LPSS: Add LNXVIDEO -> BYT I2C7 to lpss_device_links

[Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>]

On 10/24/19 4:34 PM, Rafael J. Wysocki wrote:
> On Thu, Oct 24, 2019 at 11:29 PM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> So far on Bay Trail (BYT) we only have been adding a device_link adding
>> the iGPU (LNXVIDEO) device as consumer for the I2C controller for the
>> PMIC for I2C5, but the PMIC only uses I2C5 on BYT CR (cost reduced) on
>> regular BYT platforms I2C7 is used and we were not adding the device_link
>> sometimes causing resume ordering issues.
>>
>> This commit adds LNXVIDEO -> BYT I2C7 to the lpss_device_links table,
>> fixing this.
>>
>> Cc: stable@vger.kernel.org
> 
> Thanks for these fixes, but it would be kind of nice to have Fixes:
> tags for them too.

Nice, this removes the warnings I saw on Asus T100TA
[   56.015285] i2c_designware 80860F41:00: Transfer while suspended

Thanks Hans! Feel free to take the following tag for your v2.

Tested-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Maybe an unrelated point, but with this series I now see a new message 
(logged only once):
[   46.888703] ACPI: button: The lid device is not compliant to SW_LID.

Not sure what exactly this is about, but it may be linked to the fact 
that the power button is useless to resume and somehow I have to 
close/reopen the lid to force the device to resume.

if it helps here are the traces for 2 cycles of suspend/resume.

[   34.242313] PM: suspend entry (s2idle)
[   34.246896] Filesystems sync: 0.004 seconds
[   34.247265] Freezing user space processes ... (elapsed 0.001 seconds) 
done.
[   34.249250] OOM killer disabled.
[   34.249253] Freezing remaining freezable tasks ... (elapsed 0.000 
seconds) done.
[   34.250195] printk: Suspending console(s) (use no_console_suspend to 
debug)
[   41.251352] mmc1: queuing unknown CIS tuple 0x80 (2 bytes)
[   41.252948] mmc1: queuing unknown CIS tuple 0x80 (3 bytes)
[   41.254530] mmc1: queuing unknown CIS tuple 0x80 (3 bytes)
[   41.257397] mmc1: queuing unknown CIS tuple 0x80 (7 bytes)
[   41.586893] OOM killer enabled.
[   41.586898] Restarting tasks ... done.
[   41.625298] video LNXVIDEO:00: Restoring backlight state
[   41.625718] PM: suspend exit
[   45.162584] ax88179_178a 2-1:1.0 enx00051ba24714: ax88179 - Link 
status is: 1
[   45.171220] IPv6: ADDRCONF(NETDEV_CHANGE): enx00051ba24714: link 
becomes ready
[   45.400724] ACPI: button: The lid device is not compliant to SW_LID.
[   58.478184] PM: suspend entry (s2idle)
[   58.528882] Filesystems sync: 0.051 seconds
[   58.529354] Freezing user space processes ... (elapsed 0.004 seconds) 
done.
[   58.533708] OOM killer disabled.
[   58.533712] Freezing remaining freezable tasks ... (elapsed 0.000 
seconds) done.
[   58.534648] printk: Suspending console(s) (use no_console_suspend to 
debug)
[   63.084134] mmc1: queuing unknown CIS tuple 0x80 (2 bytes)
[   63.085736] mmc1: queuing unknown CIS tuple 0x80 (3 bytes)
[   63.087337] mmc1: queuing unknown CIS tuple 0x80 (3 bytes)
[   63.090241] mmc1: queuing unknown CIS tuple 0x80 (7 bytes)
[   63.420651] OOM killer enabled.
[   63.420656] Restarting tasks ... done.
[   63.458493] video LNXVIDEO:00: Restoring backlight state
[   63.458918] PM: suspend exit
[   66.862343] ax88179_178a 2-1:1.0 enx00051ba24714: ax88179 - Link 
status is: 1
[   66.869564] IPv6: ADDRCONF(NETDEV_CHANGE): enx00051ba24714: link 
becomes ready