Re: [PATCH 1/2] ACPI: ACPICA: Add non-linux host build support

[Al Stone <ahs3@redhat.com>]

On 03/30/2017 10:53 PM, Lv Zheng wrote:
> _LINUX: used to detect a target build is a linux kernel/application.
> __linux__: used to detect a build is on a linux hosts.
> 
> Thus we can see: if a linux kernel build is performed on environments other
> than linux hosts, __linux__ may not be defined by the compiler and _LINUX
> cannot cover linux kernel resident ACPICA files, as it's only defined in
> <linux/acpi.h> and hence only allows non ACPICA kernel files to correctly
> include aclinux.h.
> As a conclusion, we don't actually support such build.
> 
> This patch adds -D_LINUX for ACPICA files so that kernel builds on any
> hosts can use unified _LINUX as a linux kernel target indication to
> correctly include aclinux.h.
> 
> Cc: Al Stone <ah3@redhat.com>
> Signed-off-by: Lv Zheng <lv.zheng@intel.com>
> ---
>  drivers/acpi/acpica/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/acpica/Makefile b/drivers/acpi/acpica/Makefile
> index 32d93ed..dea6530 100644
> --- a/drivers/acpi/acpica/Makefile
> +++ b/drivers/acpi/acpica/Makefile
> @@ -2,7 +2,7 @@
>  # Makefile for ACPICA Core interpreter
>  #
>  
> -ccflags-y			:= -Os -DBUILDING_ACPICA
> +ccflags-y			:= -Os -D_LINUX -DBUILDING_ACPICA
>  ccflags-$(CONFIG_ACPI_DEBUG)	+= -DACPI_DEBUG_OUTPUT
>  
>  # use acpi.o to put all files here into acpi.o modparam namespace
> 

These patches do solve the particular compilation problem I was having
(targeting an embedded arm64 system), so thank you for that.  The build
test obviously needs fixing, but with the Linaro aarch64-elf compilers,
and the defconfig,

Tested-by: Al Stone <ahs3@redhat.com>

-- 
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Red Hat, Inc.
ahs3@redhat.com
-----------------------------------