From: "Jürgen Groß" <jgross@suse.com>
To: "Xin Li (Intel)" <xin@zytor.com>,
linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
linux-acpi@vger.kernel.org
Cc: tglx@linutronix.de, mingo@kernel.org, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
peterz@infradead.org, boris.ostrovsky@oracle.com,
dan.carpenter@linaro.org, rafael@kernel.org, lenb@kernel.org
Subject: Re: [PATCH v1A 2/3] x86/xen/msr: Fix uninitialized symbol 'err'
Date: Sat, 17 May 2025 20:51:34 +0200 [thread overview]
Message-ID: <5f76fa30-53cf-4cdd-9201-5fd525573858@suse.com> (raw)
In-Reply-To: <20250517165713.935384-1-xin@zytor.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 798 bytes --]
On 17.05.25 18:57, Xin Li (Intel) wrote:
> xen_read_msr_safe() currently passes an uninitialized argument err to
> xen_do_read_msr(). But as xen_do_read_msr() may not set the argument,
> xen_read_msr_safe() could return err with an unpredictable value.
>
> To ensure correctness, initialize err to 0 (representing success)
> in xen_read_msr_safe().
>
> Do the same in xen_read_msr(), even err is not used after being passed
> to xen_do_read_msr().
>
> Fixes: d815da84fdd0 ("x86/msr: Change the function type of native_read_msr_safe()"
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/xen-devel/aBxNI_Q0-MhtBSZG@stanley.mountain/
> Signed-off-by: Xin Li (Intel) <xin@zytor.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2025-05-17 18:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 8:45 [PATCH v1 0/3] MSR fixes and cleanups after last round of MSR cleanups Xin Li (Intel)
2025-05-12 8:45 ` [PATCH v1 1/3] x86/msr: Remove a superfluous inclusion of <asm/asm.h> Xin Li (Intel)
2025-05-12 8:45 ` [PATCH v1 2/3] x86/xen/msr: Fix uninitialized symbol 'err' Xin Li (Intel)
2025-05-15 15:29 ` Ingo Molnar
2025-05-15 18:11 ` Xin Li
2025-05-16 13:19 ` Ingo Molnar
2025-05-16 13:42 ` Jürgen Groß
2025-05-17 16:23 ` Xin Li
2025-05-17 16:57 ` [PATCH v1A " Xin Li (Intel)
2025-05-17 18:51 ` Jürgen Groß [this message]
2025-05-12 8:45 ` [PATCH v1 3/3] x86/msr: Convert a native_wrmsr() use to native_wrmsrq() Xin Li (Intel)
2025-05-15 15:27 ` Ingo Molnar
2025-05-15 17:54 ` Xin Li
2025-05-17 4:42 ` Xin Li
2025-05-17 7:12 ` Ingo Molnar
2025-05-17 7:26 ` Xin Li
2025-05-17 13:21 ` Ingo Molnar
2025-05-17 16:25 ` Xin Li
2025-05-19 17:05 ` Xin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f76fa30-53cf-4cdd-9201-5fd525573858@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dan.carpenter@linaro.org \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox