From: "Rafael J. Wysocki" <rafael@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Hans de Goede <hansg@kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Chen Yu <yu.c.chen@intel.com>,
Maximilian Luz <luzmaximilian@gmail.com>
Subject: [PATCH v1] platform/surface: surfacepro3_button: Stop setting acpi_device_name()
Date: Mon, 06 Jul 2026 14:28:56 +0200 [thread overview]
Message-ID: <6036011.DvuYhMxLoT@rafael.j.wysocki> (raw)
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Since acpi_device_name() set by the driver is only used for input
class device name initialization and printing a message on probe
success, and SURFACE_BUTTON_DEVICE_NAME can be used instead of it
directly in both cases, make the driver do so and stop setting
acpi_device_name().
No intentional functional impact.
This will facilitate the removal of device_name from struct
acpi_device_pnp in the future.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/platform/surface/surfacepro3_button.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--- a/drivers/platform/surface/surfacepro3_button.c
+++ b/drivers/platform/surface/surfacepro3_button.c
@@ -212,11 +212,10 @@ static int surface_button_probe(struct p
goto err_free_button;
}
- strscpy(acpi_device_name(device), SURFACE_BUTTON_DEVICE_NAME);
snprintf(button->phys, sizeof(button->phys), "%s/buttons",
acpi_device_hid(device));
- input->name = acpi_device_name(device);
+ input->name = SURFACE_BUTTON_DEVICE_NAME;
input->phys = button->phys;
input->id.bustype = BUS_HOST;
input->dev.parent = &pdev->dev;
@@ -239,7 +238,7 @@ static int surface_button_probe(struct p
goto err_free_button;
}
- dev_info(&pdev->dev, "%s [%s]\n", acpi_device_name(device),
+ dev_info(&pdev->dev, SURFACE_BUTTON_DEVICE_NAME " [%s]\n",
acpi_device_bid(device));
return 0;
next reply other threads:[~2026-07-06 12:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 12:28 Rafael J. Wysocki [this message]
2026-07-06 15:32 ` [PATCH v1] platform/surface: surfacepro3_button: Stop setting acpi_device_name() Chen, Yu C
2026-07-06 15:46 ` Andy Shevchenko
2026-07-06 16:06 ` Rafael J. Wysocki (Intel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6036011.DvuYhMxLoT@rafael.j.wysocki \
--to=rafael@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox