From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19C6C218EB1; Thu, 27 Mar 2025 16:59:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743094762; cv=none; b=p4tS7+SHak4EzsbfbzbgrYLXHI+8fjhZeEy8EXw6Cw2U+Npn1MabG8oODqSwTobwiupc3seXjxKHJvlIChDxgAuu02+xQPaIt0uaROgChbIT4baDzE0scc6/E9e+3CmrNyJJqzggh8tk9oPopZwniQ22oGXqOZi/x+Vfi/5zUPA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743094762; c=relaxed/simple; bh=ZBWtgGydzDpTfxzGWzX9C6AwYBx8VOMDnHl+miUOL4E=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=g4PKwTLZLjPM0aFl23JVATrVf8dBDSZtPKkKA3ZMtLbP9DQV/xUYkPQwnUxfiNNRvlHcx9tSsk7hSefGk2Z+yYoMFidQCttYPvW6VRL0J2FPyYwQBvkpJ65XUiQnS/6BO5qIUviTiQr/2txuGkcige/tK8/irYVkAvag3+iyqt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4ZNqXr6JTqz6M4Ql; Fri, 28 Mar 2025 00:55:40 +0800 (CST) Received: from frapeml100006.china.huawei.com (unknown [7.182.85.201]) by mail.maildlp.com (Postfix) with ESMTPS id 26E2A14051A; Fri, 28 Mar 2025 00:59:11 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml100006.china.huawei.com (7.182.85.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 27 Mar 2025 17:59:10 +0100 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.039; Thu, 27 Mar 2025 17:59:10 +0100 From: Shiju Jose To: Dan Williams , "linux-cxl@vger.kernel.org" , "dave@stgolabs.net" , Jonathan Cameron , "dave.jiang@intel.com" , "alison.schofield@intel.com" , "vishal.l.verma@intel.com" , "ira.weiny@intel.com" , "david@redhat.com" , "Vilas.Sridharan@amd.com" CC: "linux-edac@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "bp@alien8.de" , "tony.luck@intel.com" , "rafael@kernel.org" , "lenb@kernel.org" , "mchehab@kernel.org" , "leo.duran@amd.com" , "Yazen.Ghannam@amd.com" , "rientjes@google.com" , "jiaqiyan@google.com" , "Jon.Grimm@amd.com" , "dave.hansen@linux.intel.com" , "naoya.horiguchi@nec.com" , "james.morse@arm.com" , "jthoughton@google.com" , "somasundaram.a@hpe.com" , "erdemaktas@google.com" , "pgonda@google.com" , "duenwen@google.com" , "gthelen@google.com" , "wschwartz@amperecomputing.com" , "dferguson@amperecomputing.com" , "wbs@os.amperecomputing.com" , "nifan.cxl@gmail.com" , tanxiaofei , "Zengtao (B)" , Roberto Sassu , "kangkang.shen@futurewei.com" , wanghuiqiang , Linuxarm Subject: RE: [PATCH v2 1/8] cxl: Add helper function to retrieve a feature entry Thread-Topic: [PATCH v2 1/8] cxl: Add helper function to retrieve a feature entry Thread-Index: AQHbmcKr5anTvL2xzU6u4SEaFigSYLOF6PqAgAFGedA= Date: Thu, 27 Mar 2025 16:59:10 +0000 Message-ID: <610691bb7c6949b5a2137c568bc66fe2@huawei.com> References: <20250320180450.539-1-shiju.jose@huawei.com> <20250320180450.539-2-shiju.jose@huawei.com> <67e47285c1974_152c29442@dwillia2-mobl3.amr.corp.intel.com.notmuch> In-Reply-To: <67e47285c1974_152c29442@dwillia2-mobl3.amr.corp.intel.com.notmuch> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 >-----Original Message----- >From: Dan Williams >Sent: 26 March 2025 21:33 >To: Shiju Jose ; linux-cxl@vger.kernel.org; >dan.j.williams@intel.com; dave@stgolabs.net; Jonathan Cameron >; dave.jiang@intel.com; >alison.schofield@intel.com; vishal.l.verma@intel.com; ira.weiny@intel.com; >david@redhat.com; Vilas.Sridharan@amd.com >Cc: linux-edac@vger.kernel.org; linux-acpi@vger.kernel.org; linux- >mm@kvack.org; linux-kernel@vger.kernel.org; bp@alien8.de; >tony.luck@intel.com; rafael@kernel.org; lenb@kernel.org; >mchehab@kernel.org; leo.duran@amd.com; Yazen.Ghannam@amd.com; >rientjes@google.com; jiaqiyan@google.com; Jon.Grimm@amd.com; >dave.hansen@linux.intel.com; naoya.horiguchi@nec.com; >james.morse@arm.com; jthoughton@google.com; somasundaram.a@hpe.com; >erdemaktas@google.com; pgonda@google.com; duenwen@google.com; >gthelen@google.com; wschwartz@amperecomputing.com; >dferguson@amperecomputing.com; wbs@os.amperecomputing.com; >nifan.cxl@gmail.com; tanxiaofei ; Zengtao (B) >; Roberto Sassu ; >kangkang.shen@futurewei.com; wanghuiqiang ; >Linuxarm ; Shiju Jose >Subject: Re: [PATCH v2 1/8] cxl: Add helper function to retrieve a feature= entry > >shiju.jose@ wrote: >> From: Shiju Jose >> >> Add helper function to retrieve a feature entry from the supported >> features list, if supported. >> >> Reviewed-by: Jonathan Cameron >> Reviewed-by: Fan Ni >> Signed-off-by: Shiju Jose >> --- >> drivers/cxl/core/core.h | 2 ++ >> drivers/cxl/core/features.c | 23 +++++++++++++++++++++++ >> 2 files changed, 25 insertions(+) >> >> diff --git a/drivers/cxl/core/core.h b/drivers/cxl/core/core.h index >> 1803aedb25ca..16bc717376fc 100644 >> --- a/drivers/cxl/core/core.h >> +++ b/drivers/cxl/core/core.h >> @@ -123,6 +123,8 @@ int cxl_ras_init(void); void cxl_ras_exit(void); >> >> #ifdef CONFIG_CXL_FEATURES >> +struct cxl_feat_entry *cxl_get_feature_entry(struct cxl_dev_state *cxld= s, >> + const uuid_t *feat_uuid); > >It is unfortunate that this naming choice is too similar to cxl_get_featur= e(). >However, as I go to suggest a new name I find that this is a duplicate of >get_support_feature_info() in Dave's fwctl series. Just drop this patch in= favor of >that. Hi Dan, I am fine to use get_support_feature_info() for the EDAC features.=20 However this function is defined as static in the fwctl series and=20 takes struct fwctl_rpc_cxl * as input for RPC instead of uuid_t * as in cxl_get_feature_entry(). static struct cxl_feat_entry * get_support_feature_info(struct cxl_features_state *cxlfs, const struct fwctl_rpc_cxl *rpc_in) Can you suggest how to use get_support_feature_info() from within the CXL d= river=20 to retrieve a supported feature entry (for e.g an EDAC feature)? > Thanks, Shiju