From: "Nuno Sá" <noname.nuno@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org,
"Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Julia Lawall <Julia.Lawall@inria.fr>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
"Cosmin Tanislav" <cosmin.tanislav@analog.com>,
"Mihail Chindris" <mihail.chindris@analog.com>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Tomislav Denis" <tomislav.denis@avl.com>,
"Marek Vasut" <marex@denx.de>,
"Olivier Moysan" <olivier.moysan@foss.st.com>,
"Fabrice Gasnier" <fabrice.gasnier@foss.st.com>,
"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Marijn Suijten" <marijn.suijten@somainline.org>,
"Marius Cristea" <marius.cristea@microchip.com>,
"Ibrahim Tilki" <Ibrahim.Tilki@analog.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v4 03/15] iio: temp: ltc2983: Use __free(fwnode_handle) to replace fwnode_handle_put() calls
Date: Mon, 19 Feb 2024 14:52:51 +0100 [thread overview]
Message-ID: <611bf0695d497219d85390d200417596086435ed.camel@gmail.com> (raw)
In-Reply-To: <20240217164249.921878-4-jic23@kernel.org>
On Sat, 2024-02-17 at 16:42 +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> This use of the new cleanup.h scope based freeing infrastructure allows
> us to exit directly from error conditions and in the good path with
> the reference obtained from fwnode_find_reference() (which may be an error
> pointer) automatically released.
>
> Cc: Cosmin Tanislav <cosmin.tanislav@analog.com>
> Cc: Nuno Sá <nuno.sa@analog.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> v2: Move the declarations down to where they are assigned.
> This both clearly associates the cleanup with the action that it
> is cleaning up and avoid potential future missordering of cleanup.
> ---
This LGTM. Only comment is that in ltc2983_parse_dt() we do have a loop where we
could make use of device_for_each_child_node_scoped(). It seems to me that
change could be included in this patch.
- Nuno Sá
next prev parent reply other threads:[~2024-02-19 13:49 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 16:42 [PATCH v4 00/15] device property / IIO: Use cleanup.h magic for fwnode_handle_put() handling Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 01/15] device property: Move fwnode_handle_put() into property.h Jonathan Cameron
2024-02-19 8:55 ` Greg Kroah-Hartman
2024-02-20 6:55 ` Sakari Ailus
2024-02-17 16:42 ` [PATCH v4 02/15] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup Jonathan Cameron
2024-02-19 8:55 ` Greg Kroah-Hartman
2024-02-20 6:55 ` Sakari Ailus
2024-02-17 16:42 ` [PATCH v4 03/15] iio: temp: ltc2983: Use __free(fwnode_handle) to replace fwnode_handle_put() calls Jonathan Cameron
2024-02-19 13:52 ` Nuno Sá [this message]
2024-02-24 11:37 ` Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 04/15] device property: Introduce device_for_each_child_node_scoped() Jonathan Cameron
2024-02-19 8:56 ` Greg Kroah-Hartman
2024-02-20 6:59 ` Sakari Ailus
2024-02-17 16:42 ` [PATCH v4 05/15] iio: adc: max11410: Use device_for_each_child_node_scoped() Jonathan Cameron
2024-02-19 13:54 ` Nuno Sá
2024-02-17 16:42 ` [PATCH v4 06/15] iio: adc: mcp3564: " Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 07/15] iio: adc: qcom-spmi-adc5: " Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 08/15] iio: adc: rzg2l_adc: " Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 09/15] iio: adc: stm32: " Jonathan Cameron
2024-02-19 11:45 ` Andy Shevchenko
2024-02-24 12:16 ` Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 10/15] iio: adc: ti-ads1015: " Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 11/15] iio: adc: ti-ads131e08: " Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 12/15] iio: addac: ad74413r: " Jonathan Cameron
2024-02-19 13:55 ` Nuno Sá
2024-02-17 16:42 ` [PATCH v4 13/15] iio: dac: ad3552r: " Jonathan Cameron
2024-02-19 11:46 ` Andy Shevchenko
2024-02-17 16:42 ` [PATCH v4 14/15] iio: dac: ad5770r: " Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 15/15] iio: dac: ltc2688: " Jonathan Cameron
2024-02-19 11:48 ` Andy Shevchenko
2024-02-19 15:48 ` Jonathan Cameron
2024-02-19 13:49 ` Nuno Sá
2024-02-19 11:49 ` [PATCH v4 00/15] device property / IIO: Use cleanup.h magic for fwnode_handle_put() handling Andy Shevchenko
2024-02-19 15:49 ` Jonathan Cameron
2024-02-24 11:49 ` Jonathan Cameron
2024-02-28 14:15 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=611bf0695d497219d85390d200417596086435ed.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Ibrahim.Tilki@analog.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Julia.Lawall@inria.fr \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cosmin.tanislav@analog.com \
--cc=djrscally@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=fabrice.gasnier@foss.st.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jic23@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=marex@denx.de \
--cc=marijn.suijten@somainline.org \
--cc=marius.cristea@microchip.com \
--cc=mihail.chindris@analog.com \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=peterz@infradead.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomislav.denis@avl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox