From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57ED5C433E2 for ; Thu, 3 Sep 2020 14:49:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25B6920786 for ; Thu, 3 Sep 2020 14:49:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XcrX6l3E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729243AbgICOte (ORCPT ); Thu, 3 Sep 2020 10:49:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40050 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728731AbgICOTO (ORCPT ); Thu, 3 Sep 2020 10:19:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599142753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oOKwAmzdX19wFLaLs6FnpWqrSpxl3eshTWS+wqlIdDI=; b=XcrX6l3ERSTzJP30/8cTunLWWZhs3qKFEtrNjrnubzLR2tT0WqWbpUzIw6xzOfrosMVKeH iiXRpD6csu/MVAXgvy31nHx+wxTpoQgN2V+fsucC7oTn4yEoAS6eBrWxKaiscranDUUjkr u+xnnLCSMjA+N7rNhLlzXphlr6vO4kg= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-489-WACayVJdNpOsGhk4yRiTeg-1; Thu, 03 Sep 2020 09:09:42 -0400 X-MC-Unique: WACayVJdNpOsGhk4yRiTeg-1 Received: by mail-ej1-f70.google.com with SMTP id y10so1210090ejd.1 for ; Thu, 03 Sep 2020 06:09:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oOKwAmzdX19wFLaLs6FnpWqrSpxl3eshTWS+wqlIdDI=; b=DY1VxK6yep+53v5iIkfFsHf4Xzo4APPjyBlqXYJCRUAQ53e1t3gc6qg+YIiOA0gd2l EjNVKV0M5JosscvcveF9AUepwrUR6vTrVFLXVzitNaOoSg8LggUG7tQg76dFon/duhZc IUi0tJtM8y3xhYzyXYRiD3AfUne9qu7ZHdJgJegixF5HRUhtvi8HYOgxg4d0NCAto9MH 0Cfsv8coT/N+UP4lbKptPTN9F0cKgDvTXqhU4iRtksahVT0VhXgmw5ws9n5y4dvqazRz WGK50Dqh7uxVD2GJ1/Jdbv15MFUITI2AvjG7dr9Q5GL1rRffTBJrFq9cRT80vEEhKkE8 hUuw== X-Gm-Message-State: AOAM530pTk3tTE51OOyoPGdpT0vk/LmmmIswDFAhzCAwUKS2qZ+TrFKR L27jEPf/kKnscKF/PBGNYV6AQqHV5H1hA/03Ef5uU0UMqa+cxpxevQuzQVMpK/kqxq4nRVnTwYk Vy115PjP2q7JtIgogep78+w== X-Received: by 2002:a17:906:d282:: with SMTP id ay2mr1910842ejb.265.1599138581377; Thu, 03 Sep 2020 06:09:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4WbCzGSIX11Eb7tLYhakyrPDa74ODNUuKAajKTh1x+4i7BJ6ADpqdzqIF9xQvFCK8/v6JPQ== X-Received: by 2002:a17:906:d282:: with SMTP id ay2mr1910818ejb.265.1599138581124; Thu, 03 Sep 2020 06:09:41 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c0c-fe00-d2ea-f29d-118b-24dc.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:d2ea:f29d:118b:24dc]) by smtp.gmail.com with ESMTPSA id v7sm3391177edd.48.2020.09.03.06.09.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Sep 2020 06:09:40 -0700 (PDT) Subject: Re: [PATCH v10 07/17] pwm: lpss: Remove suspend/resume handlers To: Andy Shevchenko Cc: Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , "Rafael J . Wysocki" , Len Brown , linux-pwm@vger.kernel.org, intel-gfx , dri-devel@lists.freedesktop.org, Mika Westerberg , linux-acpi@vger.kernel.org References: <20200903112337.4113-1-hdegoede@redhat.com> <20200903112337.4113-8-hdegoede@redhat.com> <20200903124816.GA1891694@smile.fi.intel.com> <20200903125620.GB1891694@smile.fi.intel.com> From: Hans de Goede Message-ID: <63bf5fd7-148e-262a-4076-66d2ffb58557@redhat.com> Date: Thu, 3 Sep 2020 15:09:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200903125620.GB1891694@smile.fi.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, On 9/3/20 2:56 PM, Andy Shevchenko wrote: > On Thu, Sep 03, 2020 at 03:48:16PM +0300, Andy Shevchenko wrote: >> On Thu, Sep 03, 2020 at 01:23:27PM +0200, Hans de Goede wrote: > >> the question is do we need to have similar in acpi_lpss.c? >> For example, >> static const struct lpss_device_desc byt_pwm_dev_desc = { >> .flags = LPSS_SAVE_CTX, >> ^^^^^^^^^^^^^^ >> .prv_offset = 0x800, >> .setup = byt_pwm_setup, >> }; >> >> static const struct lpss_device_desc bsw_pwm_dev_desc = { >> .flags = LPSS_SAVE_CTX | LPSS_NO_D3_DELAY, >> ^^^^^^^^^^^^^^ >> .prv_offset = 0x800, >> .setup = bsw_pwm_setup, >> }; > > Okay, it's a private space which has clock and reset gating, so means we still > need to handle it. Right I was about to say the same. As always, thank you for your reviews. Regards, Hans