Re: [PATCH v2] acpi/ghes: Prevent sleeping with spinlock held

Jonathan Cameron
2024-02-14T18:12:04Z

On Wed, 14 Feb 2024 10:23:10 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed, 14 Feb 2024 12:11:53 +0000
> Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote:
>
> > So I'm thinking this is a won't fix - wait for the printk rework to land and
> > assume this will be resolved as well?
>
> That pretty much sums up what I was about to say ;-)
>
> tp_printk is more of a hack and not to be used sparingly. With the right
> trace events it can hang the machine.
>
> So, you can use your internal patch locally, but I would recommend waiting
> for the new printk changes to land. I'm really hoping that will be soon!
>
> -- Steve

Thanks Steve,

Ira's fix is needed for other valid locking reasons - this was 'just another'
lock debugging report that came up whilst testing it.

For this patch (not a potential additional one that we aren't going to do ;)

Tested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>