From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: boqun.feng@gmail.com, linux-kernel@vger.kernel.org,
Len Brown <lenb@kernel.org>,
"open list:ACPI" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 22/30] ACPI: OSL: Add missing annotation for acpi_os_acquire_lock()
Date: Wed, 04 Mar 2020 12:00:19 +0100 [thread overview]
Message-ID: <6715482.taCdthcxpl@kreacher> (raw)
In-Reply-To: <20200223231711.157699-23-jbi.octave@gmail.com>
On Monday, February 24, 2020 12:17:03 AM CET Jules Irenge wrote:
> Sparse reports a warning at acpi_os_acquire_lock()
>
> warning: context imbalance in acpi_os_acquire_lock() - unexpected unlock
>
> The root cause is the missing annotation at acpi_os_acquire_lock()
> Add the missing annotation __acquires(lockp)
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/acpi/osl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 41168c027a5a..7094abc5ffc6 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -1598,6 +1598,7 @@ void acpi_os_delete_lock(acpi_spinlock handle)
> */
>
> acpi_cpu_flags acpi_os_acquire_lock(acpi_spinlock lockp)
> + __acquires(lockp)
> {
> acpi_cpu_flags flags;
> spin_lock_irqsave(lockp, flags);
>
Merged with the [23/30] and applied with modified subject and changelog as
5.7 material.
Thanks!
next prev parent reply other threads:[~2020-03-04 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/30>
[not found] ` <20200223231711.157699-1-jbi.octave@gmail.com>
2020-02-23 23:17 ` [PATCH 22/30] ACPI: OSL: Add missing annotation for acpi_os_acquire_lock() Jules Irenge
2020-03-04 11:00 ` Rafael J. Wysocki [this message]
2020-02-23 23:17 ` [PATCH 23/30] ACPI: OSL: Add missing annotation for acpi_os_release_lock() Jules Irenge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6715482.taCdthcxpl@kreacher \
--to=rjw@rjwysocki.net \
--cc=boqun.feng@gmail.com \
--cc=jbi.octave@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox