* [PATCH 22/30] ACPI: OSL: Add missing annotation for acpi_os_acquire_lock()
[not found] ` <20200223231711.157699-1-jbi.octave@gmail.com>
@ 2020-02-23 23:17 ` Jules Irenge
2020-03-04 11:00 ` Rafael J. Wysocki
2020-02-23 23:17 ` [PATCH 23/30] ACPI: OSL: Add missing annotation for acpi_os_release_lock() Jules Irenge
1 sibling, 1 reply; 3+ messages in thread
From: Jules Irenge @ 2020-02-23 23:17 UTC (permalink / raw)
To: boqun.feng
Cc: jbi.octave, linux-kernel, Rafael J. Wysocki, Len Brown,
open list:ACPI
Sparse reports a warning at acpi_os_acquire_lock()
warning: context imbalance in acpi_os_acquire_lock() - unexpected unlock
The root cause is the missing annotation at acpi_os_acquire_lock()
Add the missing annotation __acquires(lockp)
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/acpi/osl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 41168c027a5a..7094abc5ffc6 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -1598,6 +1598,7 @@ void acpi_os_delete_lock(acpi_spinlock handle)
*/
acpi_cpu_flags acpi_os_acquire_lock(acpi_spinlock lockp)
+ __acquires(lockp)
{
acpi_cpu_flags flags;
spin_lock_irqsave(lockp, flags);
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 23/30] ACPI: OSL: Add missing annotation for acpi_os_release_lock()
[not found] ` <20200223231711.157699-1-jbi.octave@gmail.com>
2020-02-23 23:17 ` [PATCH 22/30] ACPI: OSL: Add missing annotation for acpi_os_acquire_lock() Jules Irenge
@ 2020-02-23 23:17 ` Jules Irenge
1 sibling, 0 replies; 3+ messages in thread
From: Jules Irenge @ 2020-02-23 23:17 UTC (permalink / raw)
To: boqun.feng
Cc: jbi.octave, linux-kernel, Rafael J. Wysocki, Len Brown,
open list:ACPI
Sparse reports a warning at acpi_os_release_lock()
warning: context imbalance in acpi_os_release_lock() - unexpected unlock
The root cause is the missing annotation at acpi_os_release_lock()
Add the missing annotation __releases(lockp)
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/acpi/osl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 7094abc5ffc6..762c5d50b8fe 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -1610,6 +1610,7 @@ acpi_cpu_flags acpi_os_acquire_lock(acpi_spinlock lockp)
*/
void acpi_os_release_lock(acpi_spinlock lockp, acpi_cpu_flags flags)
+ __releases(lockp)
{
spin_unlock_irqrestore(lockp, flags);
}
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 22/30] ACPI: OSL: Add missing annotation for acpi_os_acquire_lock()
2020-02-23 23:17 ` [PATCH 22/30] ACPI: OSL: Add missing annotation for acpi_os_acquire_lock() Jules Irenge
@ 2020-03-04 11:00 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2020-03-04 11:00 UTC (permalink / raw)
To: Jules Irenge; +Cc: boqun.feng, linux-kernel, Len Brown, open list:ACPI
On Monday, February 24, 2020 12:17:03 AM CET Jules Irenge wrote:
> Sparse reports a warning at acpi_os_acquire_lock()
>
> warning: context imbalance in acpi_os_acquire_lock() - unexpected unlock
>
> The root cause is the missing annotation at acpi_os_acquire_lock()
> Add the missing annotation __acquires(lockp)
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/acpi/osl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 41168c027a5a..7094abc5ffc6 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -1598,6 +1598,7 @@ void acpi_os_delete_lock(acpi_spinlock handle)
> */
>
> acpi_cpu_flags acpi_os_acquire_lock(acpi_spinlock lockp)
> + __acquires(lockp)
> {
> acpi_cpu_flags flags;
> spin_lock_irqsave(lockp, flags);
>
Merged with the [23/30] and applied with modified subject and changelog as
5.7 material.
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-04 11:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <0/30>
[not found] ` <20200223231711.157699-1-jbi.octave@gmail.com>
2020-02-23 23:17 ` [PATCH 22/30] ACPI: OSL: Add missing annotation for acpi_os_acquire_lock() Jules Irenge
2020-03-04 11:00 ` Rafael J. Wysocki
2020-02-23 23:17 ` [PATCH 23/30] ACPI: OSL: Add missing annotation for acpi_os_release_lock() Jules Irenge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).