From: Ira Weiny <ira.weiny@intel.com>
To: Zaid Alali <zaidal@os.amperecomputing.com>, <rafael@kernel.org>,
<lenb@kernel.org>, <james.morse@arm.com>, <tony.luck@intel.com>,
<bp@alien8.de>, <kees@kernel.org>, <gustavoars@kernel.org>,
<Jonathan.Cameron@huawei.com>, <sudeep.holla@arm.com>,
<jonathanh@nvidia.com>, <u.kleine-koenig@baylibre.com>,
<dan.carpenter@linaro.org>, <viro@zeniv.linux.org.uk>,
<ira.weiny@intel.com>, <alison.schofield@intel.com>,
<dan.j.williams@intel.com>, <gregkh@linuxfoundation.org>,
<peterz@infradead.org>, <dave.jiang@intel.com>,
<Benjamin.Cheatham@amd.com>, <linux-acpi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-hardening@vger.kernel.org>
Subject: Re: [PATCH v9 5/7] ACPI: APEI: EINJ: Create debugfs files to enter device id and syndrome
Date: Fri, 13 Jun 2025 12:21:36 -0500 [thread overview]
Message-ID: <684c5e20b406a_224b7e2947b@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20250612231327.84360-6-zaidal@os.amperecomputing.com>
Zaid Alali wrote:
> From: Tony Luck <tony.luck@intel.com>
>
> EINJv2 allows users to inject multiple errors at the same time by
> specifying the device id and syndrome bits for each error in a flex
> array.
>
> Create files in the einj debugfs directory to enter data for each
> device id and syndrome value. Note that the specification says these
> are 128-bit little-endian values. Linux doesn't have a handy helper
> to manage objects of this type.
I do wonder if it would be better to make 128 bit versions in debugfs.
Because the next person to need them is unlikely to know they exist
here...
That said this looks fine for now.
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
[snip]
next prev parent reply other threads:[~2025-06-13 17:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 23:13 [PATCH v9 0/7 RESEND] Enable EINJv2 Support Zaid Alali
2025-06-12 23:13 ` [PATCH v9 1/7] ACPI: APEI: EINJ: Fix kernel test sparse warnings Zaid Alali
2025-06-12 23:13 ` [PATCH v9 2/7] ACPI: APEI: EINJ: Enable the discovery of EINJv2 capabilities Zaid Alali
2025-06-13 16:45 ` Ira Weiny
2025-06-12 23:13 ` [PATCH v9 3/7] ACPI: APEI: EINJ: Add einjv2 extension struct Zaid Alali
2025-06-12 23:13 ` [PATCH v9 4/7] ACPI: APEI: EINJ: Discover EINJv2 parameters Zaid Alali
2025-06-13 16:57 ` Ira Weiny
2025-06-12 23:13 ` [PATCH v9 5/7] ACPI: APEI: EINJ: Create debugfs files to enter device id and syndrome Zaid Alali
2025-06-13 17:21 ` Ira Weiny [this message]
2025-06-18 15:21 ` Dan Carpenter
2025-06-18 15:30 ` Luck, Tony
2025-06-18 15:51 ` Dan Carpenter
2025-06-12 23:13 ` [PATCH v9 6/7] ACPI: APEI: EINJ: Enable EINJv2 error injections Zaid Alali
2025-06-13 17:37 ` Ira Weiny
2025-06-16 18:32 ` Zaid Alali
2025-06-12 23:13 ` [PATCH v9 7/7] ACPI: APEI: EINJ: Update the documentation for EINJv2 support Zaid Alali
2025-06-13 17:40 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=684c5e20b406a_224b7e2947b@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=Benjamin.Cheatham@amd.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=bp@alien8.de \
--cc=dan.carpenter@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=james.morse@arm.com \
--cc=jonathanh@nvidia.com \
--cc=kees@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tony.luck@intel.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zaidal@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox