From: <dan.j.williams@intel.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, <nvdimm@lists.linux.dev>,
<linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-hardening@vger.kernel.org>
Subject: Re: [PATCH v3][next] acpi: nfit: intel: avoid multiple -Wflex-array-member-not-at-end warnings
Date: Wed, 25 Jun 2025 13:33:04 -0700 [thread overview]
Message-ID: <685c5d0062f2b_1608bd10051@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <e0adad17-5d4f-4309-9975-81971597da65@embeddedor.com>
Gustavo A. R. Silva wrote:
[..]
> > I think it would be a pretty small and direct replacement:
> >
> > TRAILING_OVERLAP(struct nd_cmd_pkg, pkg, nd_payload,
> > struct nd_intel_get_security_state cmd;
> > ) nd_cmd = {
> > ...
>
> Yes, this works. Hopefully, maintainers will comment on this and let us
> know what they prefer. :)
Hey Gustavo, apologies for the latency here. I think TRAILING_OVERLAP()
looks lovely for this if only because I can read that and have an idea
what it means vs wondering what this _offset_to_fam is about and needing
to read the comment.
If you can get me that patch on top of the TRAILING_OVERLAP() branch I
can test it out and ack it to let it do in through the KSPP tree.
next prev parent reply other threads:[~2025-06-25 20:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 19:52 [PATCH v3][next] acpi: nfit: intel: avoid multiple -Wflex-array-member-not-at-end warnings Gustavo A. R. Silva
2025-06-24 19:46 ` Gustavo A. R. Silva
2025-06-25 16:56 ` Kees Cook
2025-06-25 17:31 ` Gustavo A. R. Silva
2025-06-25 20:33 ` dan.j.williams [this message]
2025-06-25 21:08 ` dan.j.williams
2025-06-25 21:43 ` Gustavo A. R. Silva
2025-06-25 22:24 ` dan.j.williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=685c5d0062f2b_1608bd10051@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=gustavo@embeddedor.com \
--cc=gustavoars@kernel.org \
--cc=ira.weiny@intel.com \
--cc=kees@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox