Linux ACPI
 help / color / mirror / Atom feed
From: Ira Weiny <ira.weiny@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
	Colin Ian King <colin.i.king@gmail.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Dave Jiang <dave.jiang@intel.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>,
	Ira Weiny <ira.weiny@intel.com>, Len Brown <lenb@kernel.org>,
	Jia He <justin.he@arm.com>, <nvdimm@lists.linux.dev>,
	<linux-acpi@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] ACPI: NFIT: Fix incorrect ndr_desc being reportedin dev_err message
Date: Thu, 4 Sep 2025 11:06:21 -0500	[thread overview]
Message-ID: <68b9b8fdb0443_70a18294b1@iweiny-mobl.notmuch> (raw)
In-Reply-To: <CAJZ5v0je-10aKyA0zeDZbqTXzjxNb7yTfsWkt_-a-7uwqYdmcA@mail.gmail.com>

Rafael J. Wysocki wrote:
> On Tue, Sep 2, 2025 at 1:46 PM Colin Ian King <colin.i.king@gmail.com> wrote:
> >
> > There appears to be a cut-n-paste error with the incorrect field
> > ndr_desc->numa_node being reported for the target node. Fix this by
> > using ndr_desc->target_node instead.
> >
> > Fixes: f060db99374e ("ACPI: NFIT: Use fallback node id when numa info in NFIT table is incorrect")
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > ---
> >  drivers/acpi/nfit/core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> > index ae035b93da08..3eb56b77cb6d 100644
> > --- a/drivers/acpi/nfit/core.c
> > +++ b/drivers/acpi/nfit/core.c
> > @@ -2637,7 +2637,7 @@ static int acpi_nfit_register_region(struct acpi_nfit_desc *acpi_desc,
> >         if (ndr_desc->target_node == NUMA_NO_NODE) {
> >                 ndr_desc->target_node = phys_to_target_node(spa->address);
> >                 dev_info(acpi_desc->dev, "changing target node from %d to %d for nfit region [%pa-%pa]",
> > -                       NUMA_NO_NODE, ndr_desc->numa_node, &res.start, &res.end);
> > +                       NUMA_NO_NODE, ndr_desc->target_node, &res.start, &res.end);
> >         }
> >
> >         /*
> > --
> 
> Dan, Dave, are you guys going to take this one, or should I take care of it?

Apologies, I should have said I'm taking this one.  It is queued up.

Thanks for the ping,
Ira

      reply	other threads:[~2025-09-04 16:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-02 11:45 [PATCH][next] ACPI: NFIT: Fix incorrect ndr_desc being reportedin dev_err message Colin Ian King
2025-09-02 15:54 ` Ira Weiny
2025-09-04 15:26 ` Rafael J. Wysocki
2025-09-04 16:06   ` Ira Weiny [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68b9b8fdb0443_70a18294b1@iweiny-mobl.notmuch \
    --to=ira.weiny@intel.com \
    --cc=colin.i.king@gmail.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=justin.he@arm.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    --cc=rafael@kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox