From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 04AAF2FBE16; Fri, 10 Oct 2025 16:54:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760115247; cv=none; b=iaCsxRhI3Wz9S6GcViV5OwOu3NI2D6Wk/F/Gm3fgqpVCcPf3m/jMAA33qoN66MT/Z0nfbgQjPkqRZcDY/rOVgoQnYXidT/G5zjhsa1XJtPtU2wqOtCZLfGQkt6uVna6IUtn5K4EjBbjxauyzWfc1TMS092qXyqoyvNTf3O7C4+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760115247; c=relaxed/simple; bh=mF4mpWbfi7uwaWEWjpu+E88aO2Y2ucveTDyYIMhCn6k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I30tb6dudMetz55nv8Sqflpnf6+H/4RFHJVr8SQZzxji/EMfMnonee+xe5YxejHKScbfE+LoKpiS6KEKrEuD5pU8lN16PWgeAjjz6bsbbhO02cxW8Epx/J+HbmdSkxEYvWJIllO0mPeot0lYbi1t/sV70Dkvpw/zIGRwYiuyDDE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6EA2D1596; Fri, 10 Oct 2025 09:53:56 -0700 (PDT) Received: from [10.1.197.69] (eglon.cambridge.arm.com [10.1.197.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AFA4E3F66E; Fri, 10 Oct 2025 09:53:58 -0700 (PDT) Message-ID: <68e9365f-17d5-49fd-ad58-e09674b729b6@arm.com> Date: Fri, 10 Oct 2025 17:53:55 +0100 Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 28/29] arm_mpam: Add kunit test for bitmap reset To: Ben Horgan , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org Cc: D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Dave Martin , Koba Ko , Shanker Donthineni , fenghuay@nvidia.com, baisheng.gao@unisoc.com, Jonathan Cameron , Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250910204309.20751-1-james.morse@arm.com> <20250910204309.20751-29-james.morse@arm.com> <848050b3-65d7-4caf-b093-7145eb782a7c@arm.com> Content-Language: en-GB From: James Morse In-Reply-To: <848050b3-65d7-4caf-b093-7145eb782a7c@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Ben, On 12/09/2025 17:06, Ben Horgan wrote: > On 9/10/25 21:43, James Morse wrote: >> The bitmap reset code has been a source of bugs. Add a unit test. >> >> This currently has to be built in, as the rest of the driver is >> builtin. >> diff --git a/drivers/resctrl/Kconfig b/drivers/resctrl/Kconfig >> index c30532a3a3a4..ef59b3057d5d 100644 >> --- a/drivers/resctrl/Kconfig >> +++ b/drivers/resctrl/Kconfig >> @@ -5,10 +5,20 @@ menuconfig ARM64_MPAM_DRIVER >> MPAM driver for System IP, e,g. caches and memory controllers. >> >> if ARM64_MPAM_DRIVER >> + > > Nit: add the empty line in an earlier patch Fixed, > Reviewed-by: Ben Horgan Thanks! James