* [PATCH] ACPI, x86: Extended error log driver depends on CONFIG_X86_LOCAL_APIC
@ 2013-11-08 22:03 Luck, Tony
0 siblings, 0 replies; only message in thread
From: Luck, Tony @ 2013-11-08 22:03 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Chen Gong, Rafael J. Wysocki, linux-acpi, linux-kernel
Randconfig build by Fengguang's robot army reported:
drivers/built-in.o: In function `extlog_print':
>> acpi_extlog.c:(.text+0xcc719): undefined reference to `boot_cpu_physical_apicid'
The config had CONFIG_SMP=n so we picked up this defintion from <asm/cpu.h>:
#define cpu_physical_id(cpu) boot_cpu_physical_apicid
But boot_cpu_physical_apicid is defined in arch/x86/kernel/apic/apic.c
which is only built if CONFIG_X86_LOCAL_APIC=y
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
Ingo: This belongs on top of x86/mce branch
drivers/acpi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 08eadb4a57cb..e11faae81ed9 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -374,7 +374,7 @@ source "drivers/acpi/apei/Kconfig"
config ACPI_EXTLOG
tristate "Extended Error Log support"
- depends on X86_MCE
+ depends on X86_MCE && X86_LOCAL_APIC
select EFI
select UEFI_CPER
default n
--
1.8.4.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-11-08 22:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-08 22:03 [PATCH] ACPI, x86: Extended error log driver depends on CONFIG_X86_LOCAL_APIC Luck, Tony
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).