From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, Robert Moore <robert.moore@intel.com>,
linux-kernel@vger.kernel.org,
Erik Schmauss <erik.schmauss@intel.com>,
devel@acpica.org
Subject: Re: [PATCH] tools/power/acpi: exclude tools/* from .gitignore pattern
Date: Fri, 31 May 2019 11:23:57 +0200 [thread overview]
Message-ID: <7038880.DppijN9Y0u@kreacher> (raw)
In-Reply-To: <1556549106-16119-1-git-send-email-yamada.masahiro@socionext.com>
On Monday, April 29, 2019 4:45:06 PM CEST Masahiro Yamada wrote:
> tools/power/acpi/.gitignore has the following entries:
>
> acpidbg
> acpidump
> ec
>
> They are intended to ignore the following build artifacts:
>
> tools/power/acpi/acpidbg
> tools/power/acpi/acpidump
> tools/power/acpi/ec
>
> However, those .gitignore entries are effective not only for the
> current directory, but also for any sub-directories.
>
> So, the following directories are also considered to be ignored:
>
> tools/power/acpi/tools/acpidbg
> tools/power/acpi/tools/acpidump
> tools/power/acpi/tools/ec
>
> They are obviously version-controlled, so should be excluded from the
> .gitignore patterns.
>
> You can fix it by prefixing the patterns with '/', which means they
> are only effective in the current directory.
>
> I also prefixed the "include" consistently. IMHO, '/' prefixing is
> safer when you intend to ignore specific files or directories.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> tools/power/acpi/.gitignore | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/power/acpi/.gitignore b/tools/power/acpi/.gitignore
> index cba3d99..f698a0e 100644
> --- a/tools/power/acpi/.gitignore
> +++ b/tools/power/acpi/.gitignore
> @@ -1,4 +1,4 @@
> -acpidbg
> -acpidump
> -ec
> -include
> +/acpidbg
> +/acpidump
> +/ec
> +/include/
>
Applied, thanks!
prev parent reply other threads:[~2019-05-31 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 14:45 [PATCH] tools/power/acpi: exclude tools/* from .gitignore pattern Masahiro Yamada
2019-04-29 14:45 ` Masahiro Yamada
2019-05-31 9:23 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7038880.DppijN9Y0u@kreacher \
--to=rjw@rjwysocki.net \
--cc=devel@acpica.org \
--cc=erik.schmauss@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.moore@intel.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox