From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corentin Chary Subject: Re: [PATCH 09/19] eeepc-laptop: support for super hybrid engine (SHE) Date: Mon, 25 May 2009 11:59:32 +0200 Message-ID: <71cd59b00905250259n358cf58r837e01dc836e2c84@mail.gmail.com> References: <45cb50e646d1560eff01c5ad0f0df3c7fd6148dd.1242453625.git.len.brown@intel.com> <71cd59b00905241023h6ecfa13axc2dc82863053cdc1@mail.gmail.com> <4A198401.3040003@tuffmail.co.uk> <200905251012.31526.corentin.chary@gmail.com> <4A1A685E.1070004@tuffmail.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-fx0-f168.google.com ([209.85.220.168]:49096 "EHLO mail-fx0-f168.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752162AbZEYJ7e convert rfc822-to-8bit (ORCPT ); Mon, 25 May 2009 05:59:34 -0400 Received: by fxm12 with SMTP id 12so1209403fxm.37 for ; Mon, 25 May 2009 02:59:34 -0700 (PDT) In-Reply-To: <4A1A685E.1070004@tuffmail.co.uk> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Alan Jenkins Cc: Grigori Goronzy , linux-acpi@vger.kernel.org, Len Brown On Mon, May 25, 2009 at 11:43 AM, Alan Jenkins wrote: > Corentin Chary wrote: >> On Sunday 24 May 2009 19:29:37 Alan Jenkins wrote: >> >>> Corentin Chary wrote: >>> >>>> On Sun, May 24, 2009 at 11:28 AM, Alan Jenkins >>>> >>>> wrote: >>>> >>>>> On 5/16/09, Len Brown wrote: >>>>> >>>>>> From: Grigori Goronzy >>>>>> >>>>>> The older eeepc-acpi driver allowed to control the SHE performan= ce >>>>>> preset through a ACPI function for just this purpose. SHE underc= locks >>>>>> and undervolts the FSB and undervolts the CPU (at preset 2, >>>>>> "powersave"), or slightly overclocks the CPU (at preset 0, >>>>>> "performance"). Preset 1 is the default setting with default clo= cks and >>>>>> voltage. >>>>>> >>>>>> The new eeepc-laptop driver doesn't support it anymore. >>>>>> The attached patch adds support for it to eeepc-laptop. It's ver= y >>>>>> straight-forward and almost trivial. >>>>>> >>>>>> Signed-off-by: Grigori Goronzy >>>>>> Signed-off-by: Corentin Chary >>>>>> Signed-off-by: Len Brown >>>>>> --- >>>>>> >>>>> Hi, out of curiosity I tried this on my EeePC 701. =A0I upgraded = the >>>>> BIOS to the latest version available a few months ago. >>>>> >>>>> I find that the file is present and can successfully be read from= =2E >>>>> The file returns the value "513". =A0If I write "1" to it, nothin= g >>>>> happens. =A0If I write "0" to it, the speakers start hissing and = the >>>>> file then returns the value "512". =A0Writing "1" again gets it b= ack to >>>>> normal. =A0There is no apparent effect on performance. >>>>> >>>>> This is stupid, because we _do_ appear to check the BIOS supporte= d >>>>> features bitmask, but that's Asus firmware for you. =A0Can you pl= ease >>>>> add an extra test, so this file only allows =A0reads or writes if= the >>>>> current value is 0 or 1? =A0If you're quick you might slip it int= o -rc8 >>>>> >> >> Hi, Can you try this patch ? It seems to works for me. >> > > Thanks, it does make the interface less confusing. The behaviour (no > performance change, hissing speakers) is the same. It works on mine (original bios). But I don't know how to see if there is a performance change. Is there a quick cpu bench ? > Do any of the models this actually works on, have only 2 different > modes? =A0I thought SHE included at least three, including an > "overclocked" mode. =A0Perhaps the cpufv file could be disabled for t= he > 701 by checking the number of modes. I know the 1000h have 3 modes. I don't for others. Does someone have such a laptop on the list ? > BTW, is there a convention for sysfs files like this? =A0You've used = "*" > to indicate the current value. =A0/sys/power/disk uses square bracket= s > instead. =A0I see the "*" could be clearer though, when the options a= re > single digits. I/O Scheduler also use brackets.. don't know is there is a strict conve= ntion. --=20 Corentin Chary http://xf.iksaif.net - http://uffs.org -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html