public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Corentin Chary <corentin.chary@gmail.com>
To: Matthew Garrett <mjg@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	rpurdie@rpsys.net, lenb@kernel.org, rui.zhang@intel.com
Subject: Re: [PATCH 3/3] eeepc-laptop: Update the backlight state when we change brightness
Date: Wed, 15 Jul 2009 11:40:08 +0200	[thread overview]
Message-ID: <71cd59b00907150240q22e8694el281cf862e71e1b66@mail.gmail.com> (raw)
In-Reply-To: <1247587564-27737-3-git-send-email-mjg@redhat.com>

On Tue, Jul 14, 2009 at 6:06 PM, Matthew Garrett<mjg@redhat.com> wrote:
> Trigger a status update when the user hits a brightness key, allowing
> userspace to present appropriate UI.
>
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
> ---
>  drivers/platform/x86/eeepc-laptop.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
> index ec560f1..fde86b3 100644
> --- a/drivers/platform/x86/eeepc-laptop.c
> +++ b/drivers/platform/x86/eeepc-laptop.c
> @@ -641,7 +641,7 @@ static int notify_brn(void)
>        struct backlight_device *bd = eeepc_backlight_device;
>        if (bd) {
>                int old = bd->props.brightness;
> -               bd->props.brightness = read_brightness(bd);
> +               backlight_force_update(bd, BACKLIGHT_UPDATE_HOTKEY);
>                return old;
>        }
>        return -1;
> --
> 1.6.2.5
>
>

This could be added to asus-laptop too. It doesn't handle brightness
changes right now (only backlight on/off) but it works the same way,
so it won't be hard to add. I'll do that as soon as your main patch is
merged.
Thanks,


-- 
Corentin Chary
http://xf.iksaif.net - http://uffs.org
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-07-15  9:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-14 16:06 [PATCH 1/3] backlight: Allow drivers to update the core, and generate events on changes Matthew Garrett
2009-07-14 16:06 ` [PATCH 2/3] ACPI: Update the backlight state when we change brightness Matthew Garrett
2009-07-14 16:06   ` [PATCH 3/3] eeepc-laptop: " Matthew Garrett
2009-07-15  9:40     ` Corentin Chary [this message]
2009-07-16 21:33 ` [PATCH 1/3] backlight: Allow drivers to update the core, and generate events on changes Michal Schmidt
2009-07-18 11:48 ` Pavel Machek
2009-09-19 23:24 ` Henrique de Moraes Holschuh
2009-09-20  4:15   ` Matthew Garrett
2009-09-20 11:16     ` Henrique de Moraes Holschuh
  -- strict thread matches above, loose matches on Subject: below --
2009-07-13 20:41 Matthew Garrett
2009-07-13 20:41 ` [PATCH 2/3] ACPI: Update the backlight state when we change brightness Matthew Garrett
2009-07-13 20:41   ` [PATCH 3/3] eeepc-laptop: " Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71cd59b00907150240q22e8694el281cf862e71e1b66@mail.gmail.com \
    --to=corentin.chary@gmail.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=rpurdie@rpsys.net \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox