public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Corentin Chary <corentin.chary@gmail.com>
To: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org,
	"Corentin Chary" <corentincj@iksaif.net>,
	stable@kernel.org, "Thomas Renninger" <trenn@suse.de>,
	"Peter Küppers" <peter-mailbox@web.de>,
	"Michael Franzl" <michaelfranzl@gmx.at>,
	"Ian Turner" <vectro@vectro.org>
Subject: Re: [PATCH] asus-laptop: change light sens default values.
Date: Thu, 10 Dec 2009 08:16:12 +0100	[thread overview]
Message-ID: <71cd59b00912092316r31228507hc34cbffe98031c56@mail.gmail.com> (raw)
In-Reply-To: <1260219950-28577-1-git-send-email-corentincj@iksaif.net>

Hi Len,
please don't forget that one (it is easy to do so as it is not part of
the last series).
Thanks,

On Mon, Dec 7, 2009 at 10:05 PM, Corentin Chary <corentincj@iksaif.net> wrote:
> The light sensor disable brightness key and
> /sys/class/backlight/ control. There was a lot of report
> from users who didn't understand why they couldn't change their
> brightness, including:
> * https://bugs.launchpad.net/bugs/222171
> * https://bugzilla.novell.com/show_bug.cgi?id=514747
> * http://bugzilla.kernel.org/show_bug.cgi?id=13671
>
> Now the light sensor is disabled, and if the user want to enable
> it, the level should be ok.
>
> The funny thing is that comments where ok, not code.
>
> Cc: stable@kernel.org
> Cc: Thomas Renninger <trenn@suse.de>
> Cc: Peter Küppers <peter-mailbox@web.de>
> Cc: Michael Franzl <michaelfranzl@gmx.at>
> Cc: Ian Turner <vectro@vectro.org>
> Signed-off-by: Corentin Chary <corentincj@iksaif.net>
> ---
>  drivers/platform/x86/asus-laptop.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index b39d2bb..849359a 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -1283,8 +1283,8 @@ static int asus_hotk_add(struct acpi_device *device)
>        hotk->ledd_status = 0xFFF;
>
>        /* Set initial values of light sensor and level */
> -       hotk->light_switch = 1; /* Default to light sensor disabled */
> -       hotk->light_level = 0;  /* level 5 for sensor sensitivity */
> +       hotk->light_switch = 0; /* Default to light sensor disabled */
> +       hotk->light_level = 5;  /* level 5 for sensor sensitivity */
>
>        if (ls_switch_handle)
>                set_light_sens_switch(hotk->light_switch);
> --
> 1.6.5.4
>
>



-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-12-10  7:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-07 21:05 [PATCH] asus-laptop: change light sens default values Corentin Chary
2009-12-10  7:16 ` Corentin Chary [this message]
2009-12-16  1:02 ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71cd59b00912092316r31228507hc34cbffe98031c56@mail.gmail.com \
    --to=corentin.chary@gmail.com \
    --cc=corentincj@iksaif.net \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=michaelfranzl@gmx.at \
    --cc=peter-mailbox@web.de \
    --cc=stable@kernel.org \
    --cc=trenn@suse.de \
    --cc=vectro@vectro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox