From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XkRRthZ3" Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5875131; Thu, 16 Nov 2023 04:52:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700139124; x=1731675124; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=f4QDrezvvE23+gVuxjkoKDCNJ2E6SLKLC02A5VExyX4=; b=XkRRthZ3BQP6Hbdmjs6+JAsbO30f64mdr+nef0yGaKdHXOkBOUJ9VzhX tE7mw5g6P5GOxSt6BDM7ftd5kIvZdrafS8wMnadFr7q3NjARs044dm2t8 jgQNBbEMuywcNFYwiFUHxrq/rjxxQGdwjLAZ2feidDU/EZuOMdOxMonrn 2KZ1PfR0YV1ro+VoyJodcKh2bMOXnrm3MwfpTNEGRNxC8z8K4rgGvylj8 4Xl4rCiLDuiV0qAPvW6UX9ttL1xQd9/28HRK+U3DJcukUmfmr0X+KyeiV wX4ov4oOXqScpc4SVVcoN4NvuLLTQaz1g9KKIbuhKnH6aojwMh4fzFWgJ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10895"; a="376126896" X-IronPort-AV: E=Sophos;i="6.04,308,1695711600"; d="scan'208";a="376126896" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2023 04:52:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10895"; a="768899030" X-IronPort-AV: E=Sophos;i="6.04,308,1695711600"; d="scan'208";a="768899030" Received: from jhsteyn-mobl1.ger.corp.intel.com ([10.252.40.9]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2023 04:51:57 -0800 Date: Thu, 16 Nov 2023 14:51:55 +0200 (EET) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Mario Limonciello cc: Karol Herbst , Lyude Paul , Alex Deucher , =?ISO-8859-15?Q?Christian_K=F6nig?= , Bjorn Helgaas , Mika Westerberg , Lukas Wunner , Danilo Krummrich , David Airlie , Daniel Vetter , Xinhui Pan , "Rafael J . Wysocki" , =?ISO-8859-15?Q?Pali_Roh=E1r?= , =?ISO-8859-15?Q?Marek_Beh=FAn?= , "Maciej W . Rozycki" , Manivannan Sadhasivam , "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , open list , "open list:RADEON and AMDGPU DRM DRIVERS" , "open list:PCI SUBSYSTEM" , "open list:ACPI" Subject: Re: [PATCH v3 3/7] PCI: Drop pci_is_thunderbolt_attached() In-Reply-To: <20231114200755.14911-4-mario.limonciello@amd.com> Message-ID: <74dcfcaf-e6d4-dec8-4227-a4caf51bd4d0@linux.intel.com> References: <20231114200755.14911-1-mario.limonciello@amd.com> <20231114200755.14911-4-mario.limonciello@amd.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1230501375-1700139122=:1886" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1230501375-1700139122=:1886 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT On Tue, 14 Nov 2023, Mario Limonciello wrote: > All callers have switched to dev_is_removable() for detecting > hotpluggable PCIe devices. > > Signed-off-by: Mario Limonciello > --- > v2->v3: > * No changes > --- > include/linux/pci.h | 22 ---------------------- > 1 file changed, 22 deletions(-) > > diff --git a/include/linux/pci.h b/include/linux/pci.h > index 60ca768bc867..1fbca2bd92e8 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -2645,28 +2645,6 @@ static inline bool pci_ari_enabled(struct pci_bus *bus) > return bus->self && bus->self->ari_enabled; > } > > -/** > - * pci_is_thunderbolt_attached - whether device is on a Thunderbolt daisy chain > - * @pdev: PCI device to check > - * > - * Walk upwards from @pdev and check for each encountered bridge if it's part > - * of a Thunderbolt controller. Reaching the host bridge means @pdev is not > - * Thunderbolt-attached. (But rather soldered to the mainboard usually.) > - */ > -static inline bool pci_is_thunderbolt_attached(struct pci_dev *pdev) > -{ > - struct pci_dev *parent = pdev; > - > - if (pdev->is_thunderbolt) > - return true; > - > - while ((parent = pci_upstream_bridge(parent))) > - if (parent->is_thunderbolt) > - return true; > - > - return false; > -} > - > #if defined(CONFIG_PCIEPORTBUS) || defined(CONFIG_EEH) > void pci_uevent_ers(struct pci_dev *pdev, enum pci_ers_result err_type); > #endif > Reviewed-by: Ilpo Järvinen -- i. --8323329-1230501375-1700139122=:1886--