Re: [PATCH v4 2/3] ACPI / PMIC: Implement exec_mipi_pmic_seq_element for CHT Whiskey Cove PMIC

From: Hans de Goede <hdegoede@redhat.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v4 2/3] ACPI / PMIC: Implement exec_mipi_pmic_seq_element for CHT Whiskey Cove PMIC
Date: Fri, 14 Dec 2018 11:48:35 +0100	[thread overview]
Message-ID: <78611327-6c8d-2fe5-e3f9-af0aec9d02f7@redhat.com> (raw)
In-Reply-To: <20181214094926.GT2469@lahna.fi.intel.com>

Hi,

On 14-12-18 10:49, Mika Westerberg wrote:
> On Thu, Dec 13, 2018 at 04:35:32PM +0100, Hans de Goede wrote:
>> Implement the exec_mipi_pmic_seq_element callback for the CHT Whiskey Cove
>> PMIC.
>>
>> On some CHT devices this fixes the LCD panel not lighting up when it was
>> not initialized by the GOP, because an external monitor was plugged in and
>> the GOP initialized only the external monitor.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> 
> One question see below, but regardless
> 
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> 
>> ---
>> Changes in v4:
>> -The decoding of the raw data of the PMIC MIPI sequence element is now done
>>   in our caller, so drop this and adjust the callback prototype to accept
>>   the decoded addresses, value and mask
>>
>> Changes in v3:
>> -Use hex values for out of range checks
>> -Make intel_cht_wc_exec_mipi_pmic_seq_element return errors
>>
>> Changes in v2:
>> -Interpret data passed to the PMIC MIPI elements according to the docs
>>   instead of my own reverse engineered interpretation
>> ---
>>   drivers/acpi/pmic/intel_pmic_chtwc.c | 20 ++++++++++++++++++++
>>   1 file changed, 20 insertions(+)
>>
>> diff --git a/drivers/acpi/pmic/intel_pmic_chtwc.c b/drivers/acpi/pmic/intel_pmic_chtwc.c
>> index 078b0448f30a..c5037c5c5219 100644
>> --- a/drivers/acpi/pmic/intel_pmic_chtwc.c
>> +++ b/drivers/acpi/pmic/intel_pmic_chtwc.c
>> @@ -12,6 +12,7 @@
>>   #include <linux/mfd/intel_soc_pmic.h>
>>   #include <linux/platform_device.h>
>>   #include <linux/regmap.h>
>> +#include <asm/unaligned.h>
> 
> Why is this include needed?

It is no longer needed in v4, since the parsing of the raw
MIPI sequence data (which needed this include) has been moved
to the i915 VBT code now.

I've dropped this from my local version of the patch.

Note sure if you (Mika) are the right person to ask, but in the
coverletter of v1 I suggested merging all 3 patches through the i915 tree
since the drivers/acpi/pmic/intel_pmic* files typically do
not see all that churn.  If I can get an Ack from you or
Rafael for that then I can push the version with the include
dropped to drm-next (through drm-intel-next-queued) myself
once the 3th patch also has been acked.

Regards,

Hans

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel