Re: [PATCH v4] ACPI / APEI: release resources if gen_pool_add fails

[乱石 <zhangliguang@linux.alibaba.com>]

Hi James,

在 2019/7/25 20:46, James Morse 写道:
> Hi Liguang,
>
> On 15/07/2019 07:58, luanshi wrote:
>> To avoid memory leaks, destroy ghes_estatus_pool and release memory
>> allocated via vmalloc() on errors in ghes_estatus_pool_init().
>>
>> Signed-off-by: Liguang Zhang <zhangliguang@linux.alibaba.com>
>> ---
> Playing spot-the-difference with [v3], you've moved an empty line.
>
> Please include a change log in this space below the '---' tearoff. This helps reviewers
> know what you changed between versions, and git knows not to add stuff in here to the log.
>
> This is still:
> Reviewed-by: James Morse <james.morse@arm.com>

Thanks for your review. Because your reviewed-by was given ealier, and 
the code is reconstructed,

so I remove the reviewed-by. I will send v5 by your suggestions.

Thanks,

Liguang

>
>
> Thanks,
>
> James
>
> [v3]
> https://lore.kernel.org/linux-acpi/1561258201-26917-1-git-send-email-zhangliguang@linux.alibaba.com/
>
>
>>   drivers/acpi/apei/ghes.c | 17 ++++++++++++++---
>>   1 file changed, 14 insertions(+), 3 deletions(-)
>>
> [...]