Re: [PATCH] ACPI: AC: Remove the leftover struct acpi_ac_bl

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 9/17/22 11:45, Hanjun Guo wrote:
> In commit 57a183222271 ("ACPI / x86: Introduce an
> acpi_quirk_skip_acpi_ac_and_battery() helper"), the usage of struct
> acpi_ac_bl was removed, but left the definition of the struct in
> the file, so remove the useless code.
> 
> Signed-off-by: Hanjun Guo <guohanjun@huawei.com>

Good catch, thanks. Patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
>  drivers/acpi/ac.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
> index c29e41b..bb9fe79 100644
> --- a/drivers/acpi/ac.c
> +++ b/drivers/acpi/ac.c
> @@ -36,11 +36,6 @@
>  static int acpi_ac_remove(struct acpi_device *device);
>  static void acpi_ac_notify(struct acpi_device *device, u32 event);
>  
> -struct acpi_ac_bl {
> -	const char *hid;
> -	int hrv;
> -};
> -
>  static const struct acpi_device_id ac_device_ids[] = {
>  	{"ACPI0003", 0},
>  	{"", 0},