From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 853B7C433E0 for ; Sat, 30 May 2020 06:34:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57069207DF for ; Sat, 30 May 2020 06:34:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HYJI8j+j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728404AbgE3Gd7 (ORCPT ); Sat, 30 May 2020 02:33:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726028AbgE3Gd7 (ORCPT ); Sat, 30 May 2020 02:33:59 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDA17C03E969; Fri, 29 May 2020 23:33:58 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id e1so6283617wrt.5; Fri, 29 May 2020 23:33:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gW/FZE6q5oj2sxtuDtz4g00RRdOKFAShl0dwbYvRAAk=; b=HYJI8j+jtLKfhkp88J0NnTNLRtDgxbGZvDEyGeUkc3mA9A8Xk5g1wp979jIVnP89Tw Yui5fnLdHhbsNjI+exy8meHwdP04zsLso7H1pNh6nvkX2cfMqUQ0A8iPKiQFTt3ILY3c ycuzXxMORwnn2PgdO/RtkkiAeiRQnMOaI0gobNWE5gNu52PkVBBuV/fBeB9bVvGV0JpF f4Pf+2NfQtat5MtpdE3TGoInB7oDtFWwer5BrXg3Xu1H3xtVfuKycQKa21z51dzc3MNe YvJNtZybpqW6gIRJQCHiO+yWa+n3FCJR13SRBzJok9TxTbK4JnJ/+OLd5SLHj6iMpyOY Q4Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gW/FZE6q5oj2sxtuDtz4g00RRdOKFAShl0dwbYvRAAk=; b=kDs6jeTra52LIqvaYouK+bvvM3tpSfnOXhIh59i2N50ilPR05xRzLixhgRKA001yZ9 1ntDxgJNggbxN4gkYDPjw08kPIOiOHb3SmRCNNtkUoXhecXEtTnR4Pfa7sNerwSi1EZl NL5SHU5pgkeoXlt1OvnRG1u5fzV8Mz0CHPymI2qE23bXeK2WgTaKr9I+OBa9GYqeZQeU zQPQdNN7j39XzBiV2lWFoYUqcVg5yWM854zfvgtQ7UfRXscL41N1g/9u0Ma2KjWNABpi vGT2BaYdb/7Y9ihSHJY/OGKzTNan5Os8pnia7yVGdWe56m8wSgHrJj2ZJ2mDdKo0Mv2a BfEg== X-Gm-Message-State: AOAM532g6oiKUHsokdeHNaSbyvnyFCCfTtqgwcStt2y+/YJrR4aAWuUU LNy2mass5/utIhQjy/DDqtMCujA9 X-Google-Smtp-Source: ABdhPJyNfdIFJKGNxG0jcc76V+H+fL2KydwatgVRbXcm/IBQ0JQp1oMo6gmhNhmMps0nrHWtSFI5tg== X-Received: by 2002:a5d:538e:: with SMTP id d14mr11851190wrv.174.1590820437383; Fri, 29 May 2020 23:33:57 -0700 (PDT) Received: from ?IPv6:2003:ea:8f23:5700:e4f5:72c7:87fa:d045? (p200300ea8f235700e4f572c787fad045.dip0.t-ipconnect.de. [2003:ea:8f23:5700:e4f5:72c7:87fa:d045]) by smtp.googlemail.com with ESMTPSA id v7sm2519252wme.46.2020.05.29.23.33.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 May 2020 23:33:56 -0700 (PDT) Subject: Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default") To: Matthew Garrett , Bjorn Helgaas , Bjorn Helgaas Cc: "Rafael J. Wysocki" , "linux-pci@vger.kernel.org" , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org References: <20200529202135.GA461617@bjorn-Precision-5520> <20200529205900.whx3mxuvt6ijlqwg@srcf.ucam.org> <824d63d8-668c-22c8-a303-b44e30e805e1@gmail.com> <20200529225801.szl4obsas6ndilz4@srcf.ucam.org> From: Heiner Kallweit Message-ID: <7c8cab08-e2d4-1952-1923-aa023ea67657@gmail.com> Date: Sat, 30 May 2020 08:33:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200529225801.szl4obsas6ndilz4@srcf.ucam.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 30.05.2020 00:58, Matthew Garrett wrote: > On Sat, May 30, 2020 at 12:26:17AM +0200, Heiner Kallweit wrote: > >> Current situation means that PME is unusable on all systems where >> pcie_aspm_support_enabled() returns false, what is basically every >> system except EXPERT mode is enabled and CONFIG_PCIEASPM is set. >> So we definitely need to do something. > > CONFIG_PCIEASPM is default y. I don't think there's huge value in > adding complexity to deal with it being disabled, given that the kernel > is then in a configuration that no vendor is testing against. There are > existing runtime mechanisms to disable it at runtime. > > It *was* default y. This changed with a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default") and that's what triggered the problem. If there's no easy solution, then maybe it's best to revert the change for now.