From: Hans de Goede <hdegoede@redhat.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH 4/4] platform/x86: x86-android-tablets: Add audio codec info for Lenovo Yoga Tab 3 Pro YT3-X90F
Date: Mon, 16 Oct 2023 17:34:10 +0200 [thread overview]
Message-ID: <7d3f0ecc-bbd7-41c3-413b-c024563e2941@redhat.com> (raw)
In-Reply-To: <5d777654-4700-46ad-bec2-3921d0b7d0fc@sirena.org.uk>
Hi,
On 10/16/23 16:47, Mark Brown wrote:
> On Sat, Oct 14, 2023 at 10:53:14PM +0200, Hans de Goede wrote:
>
>> + .micd_force_micbias = 1,
>> + .micd_configs = lenovo_yt3_wm5102_micd_config,
>> + .num_micd_configs = ARRAY_SIZE(lenovo_yt3_wm5102_micd_config),
>> + .micbias={
>> + [0]={ /*MICBIAS1*/
>> + .mV =2800 ,
>> + .ext_cap=1,
>
> The indentation of this section seems weird - .micbias is indented and
> the lack of spaces around =s is odd. There's also an extra space before
> the , consistently on the mV lines.
Right this is a copy and paste fail on my side, I've fixed this up
locally already, so this will be fixed in the next version.
Regards,
Hans
next prev parent reply other threads:[~2023-10-16 15:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-14 20:53 [PATCH 0/4] spi/ACPI: Add support for SPI WM5102 coded on Lenovo YT3-X90 Hans de Goede
2023-10-14 20:53 ` [PATCH 1/4] spi: Export acpi_spi_find_controller_by_adev() Hans de Goede
2023-10-14 20:53 ` [PATCH 2/4] ACPI: scan: Add LNXVIDEO HID to ignore_serial_bus_ids[] Hans de Goede
2023-10-18 11:01 ` Rafael J. Wysocki
2023-10-14 20:53 ` [PATCH 3/4] platform/x86: x86-android-tablets: Add support for SPI device instantiation Hans de Goede
2023-10-14 20:53 ` [PATCH 4/4] platform/x86: x86-android-tablets: Add audio codec info for Lenovo Yoga Tab 3 Pro YT3-X90F Hans de Goede
2023-10-15 9:15 ` Hans de Goede
2023-10-16 8:13 ` Andy Shevchenko
2023-10-16 8:58 ` Hans de Goede
2023-10-16 14:47 ` Mark Brown
2023-10-16 15:34 ` Hans de Goede [this message]
2023-10-16 17:19 ` (subset) [PATCH 0/4] spi/ACPI: Add support for SPI WM5102 coded on Lenovo YT3-X90 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d3f0ecc-bbd7-41c3-413b-c024563e2941@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox