public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@gmail.com>
To: Stelian Pop <stelian@popies.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>,
	acpi-devel@lists.sourceforge.net,
	Jean Delvare <khali@linux-fr.org>,
	Pekka Enberg <penberg@gmail.com>
Subject: Re: [PATCH, new ACPI driver] new sony_acpi driver
Date: Fri, 11 Feb 2005 14:02:19 +0200	[thread overview]
Message-ID: <84144f02050211040253e33dab@mail.gmail.com> (raw)
In-Reply-To: <20050211113636.GI3263@crusoe.alcove-fr>

On Fri, 11 Feb 2005 12:36:37 +0100, Stelian Pop <stelian@popies.net> wrote:
> +static int __init sony_acpi_add(struct acpi_device *device)
> +{
> +       acpi_status status = AE_OK;
> +       struct sony_snc *snc = NULL;
> +       int result;
> +
> +       snc = kmalloc(sizeof(struct sony_snc), GFP_KERNEL);
> +       if (!snc)
> +               return -ENOMEM;
> +       memset(snc, 0, sizeof(struct sony_snc));

Nitpick: use kcalloc() instead of kmalloc() and memset().

                                 Pekka

  reply	other threads:[~2005-02-11 12:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-10 16:18 [PATCH, new ACPI driver] new sony_acpi driver Stelian Pop
2005-02-11 10:30 ` Jean Delvare
2005-02-11 11:17   ` Stelian Pop
     [not found] ` <20050210161809.GK3493-KwDxFO93HejPHUqn3ntIkQ@public.gmane.org>
2005-02-10 19:39   ` Bruno Ducrot
     [not found]     ` <20050210193937.GH1145-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>
2005-02-11  9:16       ` Stelian Pop
2005-02-11 11:05   ` Pekka Enberg
2005-02-11 11:36   ` Stelian Pop
2005-02-11 12:02     ` Pekka Enberg [this message]
2005-02-12 13:21     ` Jean Delvare
     [not found]       ` <20050212142103.5e1a79f9.khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
2005-02-14 10:07         ` Stelian Pop
2005-02-14 12:13           ` Jean Delvare
2005-02-14 12:38             ` Stelian Pop
     [not found]               ` <20050214123822.GF3233-KwDxFO93HejPHUqn3ntIkQ@public.gmane.org>
2005-02-14 18:42                 ` Jean Delvare
     [not found]                   ` <20050214194235.073f5850.khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
2005-02-16 15:39                     ` Stelian Pop
     [not found]                       ` <20050216153924.GC4372-KwDxFO93HejPHUqn3ntIkQ@public.gmane.org>
2005-02-18 18:38                         ` Jean Delvare
     [not found]     ` <20050211113636.GI3263-KwDxFO93HejPHUqn3ntIkQ@public.gmane.org>
2005-02-16 19:12       ` Emmanuel Fleury
2005-02-15 15:30   ` Len Brown
2005-02-15 15:39     ` [ACPI] " Stelian Pop
     [not found]       ` <20050215153912.GA3523-KwDxFO93HejPHUqn3ntIkQ@public.gmane.org>
2005-02-16 19:40         ` Bruno Ducrot
2005-02-14 10:53 ` Matthew Garrett
2005-02-14 10:58   ` Stelian Pop
     [not found]     ` <20050214105837.GE3233-KwDxFO93HejPHUqn3ntIkQ@public.gmane.org>
2005-02-14 20:32       ` Vojtech Pavlik
     [not found]         ` <20050214203211.GA8007-+ZI9xUNit7I@public.gmane.org>
2005-02-15 16:14           ` Romano Giannetti
     [not found]             ` <20050215161412.GC20951-NfIQswJzSEaq9fEpoSJUslHdEuJhDOxL@public.gmane.org>
2005-02-16 14:41               ` Stelian Pop
     [not found]                 ` <20050216144156.GA4372-KwDxFO93HejPHUqn3ntIkQ@public.gmane.org>
2005-02-16 15:40                   ` Romano Giannetti
2005-02-16 23:18         ` [ACPI] " Pavel Machek
  -- strict thread matches above, loose matches on Subject: below --
2005-03-15  6:07 Yu, Luming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84144f02050211040253e33dab@mail.gmail.com \
    --to=penberg@gmail.com \
    --cc=acpi-devel@lists.sourceforge.net \
    --cc=akpm@osdl.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stelian@popies.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox