From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 901F3C433E9 for ; Mon, 15 Feb 2021 16:39:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C9D360238 for ; Mon, 15 Feb 2021 16:39:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230019AbhBOQio (ORCPT ); Mon, 15 Feb 2021 11:38:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27156 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232085AbhBOQiE (ORCPT ); Mon, 15 Feb 2021 11:38:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613406992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uFzj2rODJUK5q41Mv/Io7SL5b3FYccUSH7ggm3/NT4E=; b=X30O2J6iEZVAk3aSzyyBqj867oHhOCjYRcwTf8zOOES0G5DrfamN9Lymv1JVp/nmseHv5p BxsN3HjCz2dREM6sFLhRw/KYqZZZFSdNJJR37onEjzHZZEbkTu9gp2I6x/2Yd6+slpycog yfbz/0eDtCjq8hgI+mtn/Io/QgkW6ck= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-203-tUDzl31kOTyu_EK3EGqbqg-1; Mon, 15 Feb 2021 11:36:31 -0500 X-MC-Unique: tUDzl31kOTyu_EK3EGqbqg-1 Received: by mail-ej1-f72.google.com with SMTP id jz15so4843889ejc.12 for ; Mon, 15 Feb 2021 08:36:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uFzj2rODJUK5q41Mv/Io7SL5b3FYccUSH7ggm3/NT4E=; b=hKXF/tOL2c1rxCHjKJ5dRHm7IcbxO+8TfFUxEFB991IoHmtoL19Xo1gsMe9/PoIAh3 JemuyoEScUEg7UjPYcjqC+asDvRVYo8E44Nx5HsOVJApv/zHPwcXKEfiJTBCXOywTWJz 6ugoYlyPaw+0g9bBMbL/GAUlFoBSObCaa3ZfdhqEPWX5oloAUorf4iSP5n/nKSbyTTDk LWrwuMkAsLTcVGxjjUUIEGnwKluWdV14siihusMWhXXy9mXTXDRsieRQJWausZhBeHL0 AnSzgrUZk1V0NHhItYGBiFLu47ACxsXz905e/F41sN7DtrkipF7ElsilNdCipnX8rG8t H+cg== X-Gm-Message-State: AOAM533L0lUXUkqs5kUdGn4BKfprbv9hw4BxjcOr/ey9s1xC8VZSUQ4z jagYShGes+yTmVqZqP6zB2hM1OlHG4jrFOnC6FD7lwJbTQ1z/5fhpZnm3sSsJOrBDs7hIbwURGg KuW5up/U1GGjEu66fj9+TWA== X-Received: by 2002:aa7:c991:: with SMTP id c17mr5863059edt.165.1613406989842; Mon, 15 Feb 2021 08:36:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJxIS+DGtIJOghH2LW7e+kP9zUs2GEvAi9MOuAwjCAR/nA1TCdrU9hpTofc967En7cCrT+RyWQ== X-Received: by 2002:aa7:c991:: with SMTP id c17mr5863039edt.165.1613406989699; Mon, 15 Feb 2021 08:36:29 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id p16sm10478569edw.44.2021.02.15.08.36.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Feb 2021 08:36:29 -0800 (PST) Subject: Re: [PATCH v2 0/4] platform/surface: Add platform profile driver for Surface devices To: "Rafael J. Wysocki" Cc: Maximilian Luz , "Rafael J. Wysocki" , Mark Gross , Len Brown , Mark Pearson , Jiaxun Yang , Platform Driver , ACPI Devel Maling List , Linux Kernel Mailing List References: <20210211201703.658240-1-luzmaximilian@gmail.com> <898aa498-8256-d59f-9e72-0e1199b3a62a@redhat.com> <510803ab-b5b8-ce2c-e956-5539874d00bf@redhat.com> From: Hans de Goede Message-ID: <8435cc87-d92f-e1c3-97c7-e2113e0ff3a9@redhat.com> Date: Mon, 15 Feb 2021 17:36:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, On 2/15/21 4:29 PM, Rafael J. Wysocki wrote: > On Mon, Feb 15, 2021 at 4:22 PM Hans de Goede wrote: >> >> Hi, >> >> On 2/15/21 3:54 PM, Rafael J. Wysocki wrote: >>> On Mon, Feb 15, 2021 at 3:36 PM Hans de Goede wrote: >>>> >>>> Hi, >>>> >>>> On 2/11/21 9:16 PM, Maximilian Luz wrote: >>>>> This series adds a driver to provide platform profile support on 5th- >>>>> and later generation Microsoft Surface devices with a Surface System >>>>> Aggregator Module. On those devices, the platform profile can be used to >>>>> influence cooling behavior and power consumption. >>>>> >>>>> To achieve this, a new platform profile is introduced: the >>>>> 'balanced-performance' profile. >>>>> >>>>> In addition, a couple of fix-ups are performed: >>>>> - Hide CONFIG_ACPI_PLATFORM_PROFILE and change drivers so that it is >>>>> selected instead of depended on. >>>>> - Fix some references to documentation in a comment. >>>>> >>>>> Note: This series (or more specifically "platform/surface: Add platform >>>>> profile driver") depends on the "platform/surface: Add Surface >>>>> Aggregator device registry" series. >>>>> >>>>> Changes in v2: >>>>> - Introduce new 'balanced-performance' platform profile and change >>>>> profile mapping in driver. >>>>> - Perform some fix-ups for the ACPI platform profile implementation: >>>>> - Fix some references to documentation in a comment. >>>>> - Hide CONFIG_ACPI_PLATFORM_PROFILE >>>> >>>> Thanks, the entire series looks good to me, so for the series: >>>> >>>> Reviewed-by: Hans de Goede >>>> >>>> Rafael, can you (once 5.12-rc1 is out) pick 1-3/4 and then provide a >>>> stable branch for me to merge? >>> >>> Since [1-3/4] appear to be uncontroversial, so IMO it would be better >>> to merge them during the merge window, so they are present in >>> 5.12-rc1. >> >> So I just realized one problem with this plan, patch 1/4 depends >> on (modifies) Kconfig bits which are only in my tree / my 5.12 pull-req >> (which I send out earlier today). > > That should be fine. > > I will be sending the first batch of pull requests tomorrow. Then I > will wait for them to be merged and I will merge the mainline back at > that point. The new patches will be applied on top of that merge, so > if your 5.12 material is included in it, they should build without > problems. Ok, that sounds good to me. Regards, Hans