From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Subject: Re: [RFC PATCH] ACPI: bus: match of_device_id using acpi device Date: Wed, 4 Jul 2018 10:38:33 +0100 Message-ID: <8518137d-c859-657e-844f-51720f6ef8dd@arm.com> References: <1530609760-8919-1-git-send-email-srinath.mannam@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko , Srinath Mannam , Nikolaus Voss Cc: Sudeep Holla , "Rafael J. Wysocki" , Len Brown , Ray Jui , Vladimir Olovyannikov , Vikram Prakash , Scott Branden , ACPI Devel Maling List , Linux Kernel Mailing List List-Id: linux-acpi@vger.kernel.org On 04/07/18 10:32, Andy Shevchenko wrote: > On Wed, Jul 4, 2018 at 6:37 AM, Srinath Mannam > wrote: >> Hi Sudeep, Andy, >> >> Yes, This patch is to get of_device_id and then fetch data pointer. >> >> To add ACPI support in multiple drivers which are device-tree based >> and has list of of_device_ids, by using this function >> very minimal changes and can avoid acpi_device_id list in the driver. >> I will send driver changes where this function used to add ACPI >> support in following patches. >> >> Below are the changes added to add ACPI support in sdhci iproc driver >> using this function. > > So, did you get an ACPI ID for it? > That's how proper ACPI support should be done. > > P.S. What you are trying to do is being discussed with Nikolaus in [1]. > I have to NAK your approach in any case. Sorry. > +1 on NACK for this and anything else that abuse PRP0001 as a short cut approach. -- Regards, Sudeep