From: D Scott Phillips <scott@os.amperecomputing.com>
To: Hanjun Guo <guohanjun@huawei.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Robin Murphy <robin.murphy@arm.com>
Cc: linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Hanjun Guo <guohanjun@huawei.com>
Subject: Re: [PATCH] ACPI: bus: Move acpi_arm_init() to the place of after acpi_ghes_init()
Date: Tue, 10 Oct 2023 11:11:01 -0700 [thread overview]
Message-ID: <864jiyqrey.fsf@scott-ph-mail.amperecomputing.com> (raw)
In-Reply-To: <20231010082123.4167603-1-guohanjun@huawei.com>
Hanjun Guo <guohanjun@huawei.com> writes:
> acpi_agdi_init() in acpi_arm_init() will register a SDEI event, so
> it needs the SDEI subsystem to be initialized (which is done in
> acpi_ghes_init()) before the AGDI driver probing.
>
> In commit fcea0ccf4fd7 ("ACPI: bus: Consolidate all arm specific
> initialisation into acpi_arm_init()"), the acpi_agdi_init() was
> called before acpi_ghes_init() and it causes following failure:
>
> | [ 0.515864] sdei: Failed to create event 1073741825: -5
> | [ 0.515866] agdi agdi.0: Failed to register for SDEI event 1073741825
> | [ 0.515867] agdi: probe of agdi.0 failed with error -5
> | ...
> | [ 0.516022] sdei: SDEIv1.0 (0x0) detected in firmware.
>
> Fix it by moving acpi_arm_init() to the place of after
> acpi_ghes_init().
>
> Fixes: fcea0ccf4fd7 ("ACPI: bus: Consolidate all arm specific initialisation into acpi_arm_init()")
> Reported-by: D Scott Phillips <scott@os.amperecomputing.com>
> Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
Tested-by: D Scott Phillips <scott@os.amperecomputing.com>
Thanks Hanjun and Sudeep
next prev parent reply other threads:[~2023-10-10 18:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 8:21 [PATCH] ACPI: bus: Move acpi_arm_init() to the place of after acpi_ghes_init() Hanjun Guo
2023-10-10 8:50 ` Sudeep Holla
2023-10-10 9:30 ` Robin Murphy
2023-10-10 9:44 ` Sudeep Holla
2023-10-10 14:10 ` Jean-Philippe Brucker
2023-10-10 18:11 ` D Scott Phillips [this message]
2023-10-18 11:30 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864jiyqrey.fsf@scott-ph-mail.amperecomputing.com \
--to=scott@os.amperecomputing.com \
--cc=guohanjun@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox