Re: [PATCH 1/1] ACPI: video: Add Toshiba Satellite/Portege Z830 quirk

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 8/31/22 15:44, Arvid Norlander wrote:
> Hi,
> 
> 
> On 2022-08-29 20:58, Hans de Goede wrote:
>> Hi,
>>
>> On 8/29/22 20:30, Arvid Norlander wrote:
>>> Hi,
>>>
>>> On 2022-08-29 16:12, Hans de Goede wrote:
>>>> Hi,
>>>>
>>>
>>> <snip>
>>>
>>>>
>>>> Arvid, here is a git branch with my backlight-refactor for you
>>>> to test:
>>>>
>>>> https://github.com/jwrdegoede/linux-sunxi/commits/backlight-refactor-for-arvid
>>>>
>>>> If you can give this a test spin (without any special kernel
>>>> commandline options) then that would be great.
>>>
>>> I'll set up a PKGBUILD and get this built (I'm building on other computers).
>>> It may take a couple of days before I get around to that however. I hope
>>> this is okay with you.
>>
>> Yes that is fine, thank you.
> 
> Just and update to let you know that your tree works, at least for suspend.

Great, thank you so much for testing this!

Is it ok if I add a:

Tested-by: Arvid Norlander <lkml@vorpal.se>

to the 2 patches for fixing this to give you credit for your testing ?

> I'm not set up to test hibernation (using swap file on btrfs). Nor do I
> know if it even works on this laptop. It has some sort of auto hibernate
> feature in BIOS called Intel Rapid Start. It supposedly auto transitions to
> hibernation after being asleep for a while. I have not looked into if this
> is supported on Linux, and what setup would be required to support it in
> that case.

Regular suspend/resume testing is what I was looking for. On restore
from hibernation the backlight is already on when restoring the state so
I don't expect any problems there.  And as you indicate getting hibernation
to work is tricky in general, IMHO there is no need to go through all
the trouble necessary to (maybe) get that to work.

Regards,

Hans