From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F8F22EBB81; Thu, 30 Oct 2025 16:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761843362; cv=none; b=IV9tJqofVzz4RudvRhba/Ev4yqHy3+GkI4TswXCECGA+kb5IdaYqEKJSghjQf+IxbTFQEJqRcmR+sFsQuHEi/sOir3z4nrESwwkylZhhmrT+m/yn21N/8KPZJwrX/+JeO9UB8NZfn0xg7VtnSqJHQEJKtGZ4xc46hhhspL+GOtI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761843362; c=relaxed/simple; bh=TSkKPAea4VwmtNaIMxByl43L8U9cQGcR3r6GSkUPrnE=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=c9SKDhjDJol3eZsas/EvM+oYInPYpFL/3h+YDl8etagL4GjUsEEqQ228XuTe/D8rsC1gR7qjrCP2C7FXHiK09z7KrjFTeLnn/YrswLhf3XCyf8lWDk7oQL3Gj7w/PpeZHYhBWf6fxnFk6HBe+77gJ3GTHbpGVdktZFI1n2jlicU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OLZNmM5s; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OLZNmM5s" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF046C4CEF1; Thu, 30 Oct 2025 16:56:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761843362; bh=TSkKPAea4VwmtNaIMxByl43L8U9cQGcR3r6GSkUPrnE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OLZNmM5so9aVLzC+KrJnz9ti13IloyA41Zyc1qR+ig2tvg5jr51nm2rZAWAeYVr7l 2VPUuL3Q1TlIpfskHooe3MfuICA6hdqnd58416e3/wpTLIXHi954/bnh8cUO/w1HgL V0U3hcRsWd6W5v1JGvtIEHZVK9AeY8i/l5vSfLIOOOksWPuz8wLDWVOVYAQ5XWSCtJ ZNG+vcB3kbYkNo1BM/vLF41dmQg0nB6kHsJak4UA+nQ82bTRqT+dR1a5wTEFkrPDsH 6fqQjIdEhwVAe4qEt9RwpPT4nudhZox+LMC+vAlOVmVsvt2jeAytkikFJuEH48WZhM 7oC/es6HGM86A== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vEVwN-000000013xM-3dZz; Thu, 30 Oct 2025 16:55:59 +0000 Date: Thu, 30 Oct 2025 16:55:59 +0000 Message-ID: <86pla4uy5c.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Daniel Lezcano , Thomas Gleixner , Mark Rutland , Alexandru Elisei , Steven Price Subject: Re: [PATCH v2 3/4] clocksource/drivers/arm_arch_timer_mmio: Switch over to standalone driver In-Reply-To: References: <20250814154622.10193-1-maz@kernel.org> <20250814154622.10193-4-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lpieralisi@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, guohanjun@huawei.com, sudeep.holla@arm.com, rafael@kernel.org, daniel.lezcano@linaro.org, tglx@linutronix.de, mark.rutland@arm.com, alexandru.elisei@arm.com, steven.price@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 30 Oct 2025 16:35:11 +0000, Lorenzo Pieralisi wrote: > > On Thu, Aug 14, 2025 at 04:46:21PM +0100, Marc Zyngier wrote: > > [...] > > > diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c > > [...] > > > #ifdef CONFIG_ACPI_GTDT > > -static int __init > > -arch_timer_mem_verify_cntfrq(struct arch_timer_mem *timer_mem) > > -{ > > - struct arch_timer_mem_frame *frame; > > - u32 rate; > > - int i; > > - > > - for (i = 0; i < ARCH_TIMER_MEM_MAX_FRAMES; i++) { > > - frame = &timer_mem->frame[i]; > > - > > - if (!frame->valid) > > - continue; > > - > > - rate = arch_timer_mem_frame_get_cntfrq(frame); > > - if (rate == arch_timer_rate) > > - continue; > > - > > - pr_err(FW_BUG "CNTFRQ mismatch: frame @ %pa: (0x%08lx), CPU: (0x%08lx)\n", > > - &frame->cntbase, > > - (unsigned long)rate, (unsigned long)arch_timer_rate); > > - > > - return -EINVAL; > > - } > > - > > - return 0; > > -} > > - > > -static int __init arch_timer_mem_acpi_init(int platform_timer_count) > > -{ > > - struct arch_timer_mem *timers, *timer; > > - struct arch_timer_mem_frame *frame, *best_frame = NULL; > > - int timer_count, i, ret = 0; > > - > > - timers = kcalloc(platform_timer_count, sizeof(*timers), > > - GFP_KERNEL); > > - if (!timers) > > - return -ENOMEM; > > - > > - ret = acpi_arch_timer_mem_init(timers, &timer_count); > > You probably already noticed (I was checking the initcall level in > drivers/acpi/arm64/gtdt.c to start sorting out GICv5 IWB dependencies), > AFAICS acpi_arch_timer_mem_init() is now unused so it can be removed. See https://lore.kernel.org/r/20251030110137.1843007-1-maz@kernel.org Thanks, M. -- Without deviation from the norm, progress is not possible.