From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E052A24BBEE; Mon, 20 Oct 2025 10:47:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760957230; cv=none; b=l42WA6D5po8kRxid5T8f+kLhDJhEu2K3+xWw9qcy9X66jujs27JdQH76+W/bCkGqtQDeTw0MmRDF89GDWQTpZOWFIPjLjOi4m1DkWGuGo4qoGykiHRZUx71KVPASVTaOECiz6Y3K13jq44T6Ygaedxh/O2xo/numNy9ZPBcgqew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760957230; c=relaxed/simple; bh=aRCKuRMfy54t4bXfC91JSBbnFrkYdLdzDBFthyWBges=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=SPhAThBDoG+6CeCP/gECG3c4LpV+S5KWDX4J53RUyoE/FD8IuaijauPKIN8EwTeLgPQk4AdGU8ffFXrGZl/pZ9aokxzjNRJBvmrfBApkCiQ318f/eu0+sYFppEljvDtXJ+SzAf7uDvHWLDVG4xJHs4x2e0jgWpaYqYgcNQNMDH0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=C5wXs9Ur; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C5wXs9Ur" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45EF9C4CEF9; Mon, 20 Oct 2025 10:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760957227; bh=aRCKuRMfy54t4bXfC91JSBbnFrkYdLdzDBFthyWBges=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C5wXs9UrwAszdToIyQFZOKA+qjfH1I2yEPkUwkzif5j4NUpLKHFN+GMhrhIqgexug RION/AebVZepdsmtOasBwAWiACN37Gehlt1tI8qJg7HtryTMMo10HtKPrCYnzR4mqe 4+PULhz1P29UQ7xi9xpd6H5FBB+GABK10UO1niUyk/RDp0/kyX2pLnbML9flNDcQzL aYW2fXSJMZ3lR3hb360j2riGA3jr36dSUWNgOK7M5tcBXGGa9PTP6H75+SqYahWyFO kMCmQhwDcBIhvdGNxp8m1U8ycZ8ibkyN4OjbXeseDCjOCx9Rphnry3738s2aUJRn3N wCconD0AwTHAg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vAnPt-0000000FSul-0I6N; Mon, 20 Oct 2025 10:47:05 +0000 Date: Mon, 20 Oct 2025 11:47:04 +0100 Message-ID: <86plahx32v.wl-maz@kernel.org> From: Marc Zyngier To: Jonathan Cameron Cc: , , , Thomas Gleixner , "Mark\ Rutland" , Will Deacon , "Rafael J.\ Wysocki" , Rob Herring , "Saravana\ Kannan" , Greg Kroah-Hartman , Sven Peter , Janne Grunau , Suzuki K Poulose , James Clark Subject: Re: [PATCH v3 03/26] of/irq: Add IRQ affinity reporting interface In-Reply-To: <20251009174959.00001b05@huawei.com> References: <20250922082833.2038905-1-maz@kernel.org> <20250922082833.2038905-4-maz@kernel.org> <20251009174959.00001b05@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: jonathan.cameron@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, tglx@linutronix.de, mark.rutland@arm.com, will@kernel.org, rafael@kernel.org, robh@kernel.org, saravanak@google.com, gregkh@linuxfoundation.org, sven@kernel.org, j@jannau.net, suzuki.poulose@arm.com, james.clark@linaro.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 09 Oct 2025 17:49:59 +0100, Jonathan Cameron wrote: > > On Mon, 22 Sep 2025 09:28:10 +0100 > Marc Zyngier wrote: > > > Plug the irq_populate_fwspec_info() helper into the OF layer > > to offer an IRQ affinity reporting function. > > > > Signed-off-by: Marc Zyngier > Trivial comment inline but I don't care that much. > Reviewed-by: Jonathan Cameron > > > --- > > drivers/of/irq.c | 20 ++++++++++++++++++++ > > include/linux/of_irq.h | 7 +++++++ > > 2 files changed, 27 insertions(+) > > > > diff --git a/drivers/of/irq.c b/drivers/of/irq.c > > index 74aaea61de13c..9a205cb033bda 100644 > > --- a/drivers/of/irq.c > > +++ b/drivers/of/irq.c > > @@ -479,6 +479,26 @@ int of_irq_get(struct device_node *dev, int index) > > } > > EXPORT_SYMBOL_GPL(of_irq_get); > > > > +const struct cpumask *of_irq_get_affinity(struct device_node *dev, int index) > > +{ > > + struct of_phandle_args oirq; > > + struct irq_fwspec_info info; > > + struct irq_fwspec fwspec; > > + int rc; > > + > > + rc = of_irq_parse_one(dev, index, &oirq); > > + if (rc) > > + return NULL; > > + > > + of_phandle_args_to_fwspec(oirq.np, oirq.args, oirq.args_count, > > + &fwspec); > > + > > + if (!irq_populate_fwspec_info(&fwspec, &info)) > > + return info.affinity; > My slightly picky mental consistency filter suggests that this would look > more like the ACPI version as > > if (irq_populate_fwspec_info(&fwspec, &info)) > return NULL; > > return info.affinity; > > But I don't really care. Consistency doesn't hurt. I've applied this. Thanks, M. -- Without deviation from the norm, progress is not possible.