From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH 0/7] al-msi: Rename driver and add support for ACPI Date: Mon, 01 Apr 2019 03:02:17 +0100 Message-ID: <86r2am5vpy.wl-marc.zyngier@arm.com> References: <1554035655-11352-1-git-send-email-hhhawa@amazon.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1554035655-11352-1-git-send-email-hhhawa@amazon.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Hanna Hawa Cc: catalin.marinas@arm.com, will.deacon@arm.com, jonnyc@amazon.com, ronenk@amazon.com, Lorenzo Pieralisi , vaerov@amazon.com, linux@armlinux.org.uk, talel@amazon.com, linux-acpi@vger.kernel.org, alisaidi@amazon.com, lenb@kernel.org, jason@lakedaemon.net, antoine.tenart@bootlin.com, zeev@amazon.com, tglx@linutronix.de, hanochu@amazon.com, linux-arm-kernel@lists.infradead.org, barakw@amazon.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, tsahee@annapurnalabs.com, dwmw@amazon.co.uk List-Id: linux-acpi@vger.kernel.org On Sun, 31 Mar 2019 13:34:08 +0100, Hanna Hawa wrote: > > This series includes three major changes: > 1. IOMMU DMA mapping MSI message fix. > 2. Re-name the AL-MSIx driver to new name convention. > 3. Add ACPI support for the driver. > > Alpine is the name of the SoC family, while AL stands for Annapurna > Labs. Rename to the latter since the driver will appear in other SoC > families other than Alpine. > > The AL-MSIx controller is not standard, is not included in the UEFI > specification, and will not be added. The driver ACPI binding is > performed when the following conditions are true: > - OEM ID is AMAZON > - MADT table type is 0x80 (part of the OEM reserved range). [+Lorenzo, as the arm64 ACPI maintainer] So you're happy to explicitly violate the letter of the specification? That's not really going to fly. We've pushed back on such things in the past (MBIGEN, XGene MSI controller), and I don't see any compelling reason to change our tune. > GICv2m driver is called from context of parent interrupt controller, > which ensures that the parent interrupt domain exists and holds valid > information. As calling AL-MSIx driver from GICv3 driver would not make > sense, a new API was added, to get the GSI IRQ domain that was registered > by GICv3 driver in the ACPI framework. What does this mean? Either your system has a GICv2m or it has a GICv3. Please explain what this is all about. Thanks, M. -- Jazz is not dead, it just smell funny.