From: Marc Zyngier <marc.zyngier@arm.com>
To: Hanna Hawa <hhhawa@amazon.com>
Cc: tsahee@annapurnalabs.com, antoine.tenart@bootlin.com,
linux@armlinux.org.uk, catalin.marinas@arm.com,
will.deacon@arm.com, rjw@rjwysocki.net, lenb@kernel.org,
tglx@linutronix.de, jason@lakedaemon.net, ronenk@amazon.com,
dwmw@amazon.co.uk, vaerov@amazon.com, zeev@amazon.com,
alisaidi@amazon.com, talel@amazon.com, jonnyc@amazon.com,
hanochu@amazon.com, barakw@amazon.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 3/7] irqchip/al-msi: Rename AL-MSIx driver
Date: Mon, 01 Apr 2019 02:49:17 +0100 [thread overview]
Message-ID: <86sgv25wbm.wl-marc.zyngier@arm.com> (raw)
In-Reply-To: <1554035655-11352-4-git-send-email-hhhawa@amazon.com>
On Sun, 31 Mar 2019 13:34:11 +0100,
Hanna Hawa <hhhawa@amazon.com> wrote:
>
> Alpine is the name of the SoC family, while AL stands for Annapurna
> Labs. Rename to the latter since the driver will appear in other SoC
> families other than Alpine.
>
> Add device tree match for "amazon/al-msix".
>
> Signed-off-by: Hanna Hawa <hhhawa@amazon.com>
> ---
> arch/arm/mach-alpine/Kconfig | 2 +-
> arch/arm64/Kconfig.platforms | 2 +-
> drivers/irqchip/Kconfig | 2 +-
> drivers/irqchip/Makefile | 2 +-
> drivers/irqchip/{irq-alpine-msi.c => irq-al-msi.c} | 93 +++++++++++-----------
> 5 files changed, 49 insertions(+), 52 deletions(-)
> rename drivers/irqchip/{irq-alpine-msi.c => irq-al-msi.c} (68%)
Why do we need this churn? It feels absolutely pointless. Adding your
new compatibility string is absolutely fine; repainting the whole
driver because you've found a "better" name for it isn't.
Thanks,
M.
--
Jazz is not dead, it just smell funny.
next prev parent reply other threads:[~2019-04-01 1:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 12:34 [PATCH 0/7] al-msi: Rename driver and add support for ACPI Hanna Hawa
2019-03-31 12:34 ` [PATCH 1/7] irqchip/alpine-msi: Call IOMMU DMA mapping MSI message hook Hanna Hawa
2019-03-31 12:34 ` [PATCH 2/7] irqchip/alpine-msi: Update driver license to use SPDX Hanna Hawa
2019-03-31 12:46 ` Mukesh Ojha
2019-03-31 13:00 ` Hawa, Hanna
2019-04-01 11:52 ` David Woodhouse
2019-03-31 12:34 ` [PATCH 3/7] irqchip/al-msi: Rename AL-MSIx driver Hanna Hawa
2019-04-01 1:49 ` Marc Zyngier [this message]
2019-03-31 12:34 ` [PATCH 4/7] irqchip/al-msi: Update wrong parameter naming Hanna Hawa
2019-04-01 2:02 ` [PATCH 0/7] al-msi: Rename driver and add support for ACPI Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86sgv25wbm.wl-marc.zyngier@arm.com \
--to=marc.zyngier@arm.com \
--cc=alisaidi@amazon.com \
--cc=antoine.tenart@bootlin.com \
--cc=barakw@amazon.com \
--cc=catalin.marinas@arm.com \
--cc=dwmw@amazon.co.uk \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=jason@lakedaemon.net \
--cc=jonnyc@amazon.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rjw@rjwysocki.net \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
--cc=tglx@linutronix.de \
--cc=tsahee@annapurnalabs.com \
--cc=vaerov@amazon.com \
--cc=will.deacon@arm.com \
--cc=zeev@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox