From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH 3/7] irqchip/al-msi: Rename AL-MSIx driver Date: Mon, 01 Apr 2019 02:49:17 +0100 Message-ID: <86sgv25wbm.wl-marc.zyngier@arm.com> References: <1554035655-11352-1-git-send-email-hhhawa@amazon.com> <1554035655-11352-4-git-send-email-hhhawa@amazon.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <1554035655-11352-4-git-send-email-hhhawa@amazon.com> Sender: linux-kernel-owner@vger.kernel.org To: Hanna Hawa Cc: tsahee@annapurnalabs.com, antoine.tenart@bootlin.com, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, rjw@rjwysocki.net, lenb@kernel.org, tglx@linutronix.de, jason@lakedaemon.net, ronenk@amazon.com, dwmw@amazon.co.uk, vaerov@amazon.com, zeev@amazon.com, alisaidi@amazon.com, talel@amazon.com, jonnyc@amazon.com, hanochu@amazon.com, barakw@amazon.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On Sun, 31 Mar 2019 13:34:11 +0100, Hanna Hawa wrote: > > Alpine is the name of the SoC family, while AL stands for Annapurna > Labs. Rename to the latter since the driver will appear in other SoC > families other than Alpine. > > Add device tree match for "amazon/al-msix". > > Signed-off-by: Hanna Hawa > --- > arch/arm/mach-alpine/Kconfig | 2 +- > arch/arm64/Kconfig.platforms | 2 +- > drivers/irqchip/Kconfig | 2 +- > drivers/irqchip/Makefile | 2 +- > drivers/irqchip/{irq-alpine-msi.c => irq-al-msi.c} | 93 +++++++++++----------- > 5 files changed, 49 insertions(+), 52 deletions(-) > rename drivers/irqchip/{irq-alpine-msi.c => irq-al-msi.c} (68%) Why do we need this churn? It feels absolutely pointless. Adding your new compatibility string is absolutely fine; repainting the whole driver because you've found a "better" name for it isn't. Thanks, M. -- Jazz is not dead, it just smell funny.