From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F386837289B; Tue, 16 Sep 2025 15:59:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758038399; cv=none; b=jPYoi5TX3ReAAasIp/4ITjROb/730NvrXwB4g7s7xU+FBS0F+9JvndwKjbxXE0sE3d6UebdPpGk2oAcisUU1SnxX0Psqf4Na+EQI75aBW1/Ls1qyVq5Y95Z+XGRB2ry8EtMA7Ab1illPvm7+9FIism5zR2EaZtNHivwsF0biXZ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758038399; c=relaxed/simple; bh=wr2tJyYlkR5y7T+xXW7Ilz7m2i0rIvhhJ50qSX15f1Q=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=K7uq5oxNkzM18mjAUTIBN1BckLA+YoMLI8R14v90Qj9YCRUFtPVZHRBavjYXTLIvqLrTwdHBfqEoMqja6ZnAWPFZp6S3Q69qRqLZ8MlKr5F/Br4lDswD8NDbDx/7nIny1SvxVdgsyc7SL7LgyXyHwii9pSV15bDDoicTVnT8VkA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Bl1tovBv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Bl1tovBv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BF72C4CEEB; Tue, 16 Sep 2025 15:59:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758038398; bh=wr2tJyYlkR5y7T+xXW7Ilz7m2i0rIvhhJ50qSX15f1Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Bl1tovBv/A1b3dWFDjYnUvsI3AMmg0L1t0r51/nrQVCCpwzstVSwREiaJ4NPAT6Ij aCBROW6QSv6LBn/reHoTPN07KUpdK1eTLIX1wbpAxJYlGxs2pdSJs9uPzlT27yR/F0 lBvNpc5z0rM1q2xJQXNF90n5FXiFyf+fD9WCG6pt/LIv83ILa87/6PAqEvUBKRvImp XYotFnLUUO/ranSYvN1o+U1QaMsgBiJqBVe+ATLpyWuOhemojZjcL8fZa+HGdg/FdH niss8SL/WuTI5EyOj3/xJqEozCvblDppJwo9/ktBg9K8cD0DaWAQ8KW3UpBs26pJar KmQU/zzJcmdVw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1uyY5z-00000006mKg-36KG; Tue, 16 Sep 2025 15:59:55 +0000 Date: Tue, 16 Sep 2025 16:59:55 +0100 Message-ID: <86tt121j7o.wl-maz@kernel.org> From: Marc Zyngier To: Jonathan Cameron Cc: , , , Thomas Gleixner , "Mark\ Rutland" , Will Deacon , "Rafael J.\ Wysocki" , Rob Herring , "Saravana\ Kannan" , Greg Kroah-Hartman , Sven Peter , Janne Grunau , Suzuki K Poulose , James Clark Subject: Re: [PATCH v2 05/25] irqchip/gic-v3: Add FW info retrieval support In-Reply-To: <20250916163413.000062f0@huawei.com> References: <20250915085702.519996-1-maz@kernel.org> <20250915085702.519996-6-maz@kernel.org> <20250916163413.000062f0@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: jonathan.cameron@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, tglx@linutronix.de, mark.rutland@arm.com, will@kernel.org, rafael@kernel.org, robh@kernel.org, saravanak@google.com, gregkh@linuxfoundation.org, sven@kernel.org, j@jannau.net, suzuki.poulose@arm.com, james.clark@linaro.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 16 Sep 2025 16:34:13 +0100, Jonathan Cameron wrote: > > On Mon, 15 Sep 2025 09:56:42 +0100 > Marc Zyngier wrote: > > > Plug the new .get_info() callback into the GICv3 core driver, > > using some of the existing PPI affinity handling infrastructure. > > > > Signed-off-by: Marc Zyngier > Hi Marc, > > Yet another trivial comment. It's one of those days it seems :) No worries, your trivial comments are far more interesting than some of the emails I'm otherwise getting.. ;-) > > > --- > > drivers/irqchip/irq-gic-v3.c | 53 ++++++++++++++++++++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > > > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > > index dbeb85677b08c..71c278ddd1e39 100644 > > --- a/drivers/irqchip/irq-gic-v3.c > > +++ b/drivers/irqchip/irq-gic-v3.c > > @@ -69,6 +69,8 @@ struct gic_chip_data { > > bool has_rss; > > unsigned int ppi_nr; > > struct partition_desc **ppi_descs; > > + struct partition_affinity *parts; > > + unsigned int nr_parts; > > }; > > > > #define T241_CHIPS_MAX 4 > > @@ -1796,11 +1798,58 @@ static int gic_irq_domain_select(struct irq_domain *d, > > return d == partition_get_domain(gic_data.ppi_descs[ppi_idx]); > > } > > > > +static int gic_irq_get_fwspec_info(struct irq_fwspec *fwspec, struct irq_fwspec_info *info) > > +{ > > + const struct cpumask *mask = NULL; > > + > > + info->flags = 0; > > + info->affinity = NULL; > > + > > + /* ACPI is not capable of describing PPI affinity -- yet */ > > + if (!is_of_node(fwspec->fwnode)) > > + return 0; > > + > > + /* If the specifier provides an affinity, use it */ > > + if (fwspec->param_count == 4 && fwspec->param[3]) { > > + struct fwnode_handle *fw; > > + > > + switch (fwspec->param[0]) { > > + case 1: /* PPI */ > > + case 3: /* EPPI */ > > + break; > > + default: > > + return 0; > > + } > > + > > + fw = of_node_to_fwnode(of_find_node_by_phandle(fwspec->param[3])); > > of_node_to_fwnode() has a note that says it'll be removed in the merge window. > It was enough of an oddity I wondered why it existed. Cargo culted, obviously. And yet another sign that I've been sitting on these patches for way too long... > Of course it did say it would be removed in the previous merge window and wasn't... > Probably want of_fwnode_handle() Thanks for the hint, I'll add that to v3. M. -- Without deviation from the norm, progress is not possible.