Re: wrong documentation for /proc/acpi/sleep?

Re: wrong documentation for /proc/acpi/sleep?

[Len Brown]

On Thu, 2005-09-15 at 16:00 -0400, Jochen Hein wrote:
> 
> The documentation in Documentation/power/swsusp.txt reads:
> 
> ,----
> | Sleep states summary
> | ====================
> |
> | There are three different interfaces you can use, /proc/acpi should
> | work like this:
> |
> | In a really perfect world:
> | echo 1 > /proc/acpi/sleep       # for standby
> | echo 2 > /proc/acpi/sleep       # for suspend to ram
> | echo 3 > /proc/acpi/sleep       # for suspend to ram, but with more
> | power conservative
> | echo 4 > /proc/acpi/sleep       # for suspend to disk
> | echo 5 > /proc/acpi/sleep       # for shutdown unfriendly the system
> |
> | and perhaps
> | echo 4b > /proc/acpi/sleep      # for suspend to disk via s4bios
> `----

You're right, swsusp.txt is out of date.
/proc/acpi/sleep is deprecated -- and the S2 comment was nonsense from
the start.

> I do get:
> root@hermes:~# echo 2 > /proc/acpi/sleep
> bash: /proc/acpi/sleep: No such file or directory
> 
> Kernel release is 2.6.14-rc1, ACPI/Power-related-config:
> ,----
> | root@hermes:/usr/src/linux-2.6.14-rc1# grep ACPI .config
> | # Power management options (ACPI, APM)
> | # ACPI (Advanced Configuration and Power Interface) Support
> | CONFIG_ACPI=y
> | CONFIG_ACPI_AC=y
> | CONFIG_ACPI_BATTERY=y
> | CONFIG_ACPI_BUTTON=y
> | CONFIG_ACPI_VIDEO=y
> | CONFIG_ACPI_HOTKEY=y
> | CONFIG_ACPI_FAN=y
> | CONFIG_ACPI_PROCESSOR=y
> | CONFIG_ACPI_THERMAL=y
> | # CONFIG_ACPI_ASUS is not set
> | CONFIG_ACPI_IBM=y
> | # CONFIG_ACPI_TOSHIBA is not set
> | CONFIG_ACPI_BLACKLIST_YEAR=0
> | CONFIG_ACPI_DEBUG=y
> | CONFIG_ACPI_EC=y
> | CONFIG_ACPI_POWER=y
> | CONFIG_ACPI_SYSTEM=y
> | # CONFIG_ACPI_CONTAINER is not set
> | CONFIG_X86_ACPI_CPUFREQ=y
> | CONFIG_X86_SPEEDSTEP_CENTRINO_ACPI=y
> | # CONFIG_X86_ACPI_CPUFREQ_PROC_INTF is not set
> | # CONFIG_HOTPLUG_PCI_ACPI is not set
> | CONFIG_PNPACPI=y
> | root@hermes:/usr/src/linux-2.6.14-rc1# grep POWER .config
> | CONFIG_ACPI_POWER=y
> | # CONFIG_APM_REAL_MODE_POWER_OFF is not set
> | CONFIG_CPU_FREQ_GOV_POWERSAVE=y
> | # CONFIG_X86_POWERNOW_K6 is not set
> | # CONFIG_X86_POWERNOW_K7 is not set
> | # CONFIG_X86_POWERNOW_K8 is not set
> | # CONFIG_USB_POWERMATE is not set
> | root@hermes:/usr/src/linux-2.6.14-rc1# grep SWSU .config
> | CONFIG_SWSUSP_ENCRYPT=y
> `----
> 
> System is a Thinkpad R40, Debian/sarge with kernel 2.6.14-rc1. Did I
> miss something obvious?

Enable CONFIG_ACPI_SLEEP

for /proc/acpi/sleep, you'll need
CONFIG_ACPI_SLEEP_PROC_FS
which will allow
CONFIG_ACPI_SLEEP_PROC_SLEEP

cheers,
-Len




-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. 
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php

RE: wrong documentation for /proc/acpi/sleep?

[Brown, Len]

Seems it is pretty obscure to enable SMP SLEEP in Kconfig.

Anybody got suggestions?

it might be that we want to use "select" instead
of "depends on" here?

thanks,
-Len 

>-----Original Message-----
>From: Jochen Hein [mailto:jochen-AVN6mSxK9lsdnm+yROfE0A@public.gmane.org] 
>Sent: Friday, September 16, 2005 2:20 PM
>To: Brown, Len
>Subject: Re: [ACPI] wrong documentation for /proc/acpi/sleep?
>
>"Brown, Len" <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> writes:
>
>>>>> System is a Thinkpad R40, Debian/sarge with kernel 
>2.6.14-rc1. Did I
>>>>> miss something obvious?
>>>>
>>>> Enable CONFIG_ACPI_SLEEP
>>>
>>>Which is a maze to find, if you have SMP enabled.  Can that be made
>>>easier?  Thanks for your help.
>>
>> The idea is that /proc/acpi/sleep is deprecated --
>> it is disabled by default.  Indeed, we're deprecating
>> all of /proc/acpi as we move to sysfs -- so when equivalent
>> functions appear in sysfs, other parts of /proc/acpi
>> will be under similar non-default config options
>> solely for backwards compatibility.
>
>That's fine with me.
>
>> I'm open to suggestions for better clarity if you've got any.
>
>I asked myself, why I didn't find CONFIG_ACPI_SLEEP in menuconfig.
>Looking into drivers/acpi/Kconfig:
>
>,----
>| config ACPI_SLEEP
>|         bool "Sleep States"
>|         depends on X86 && (!SMP || SUSPEND_SMP)
>|         depends on PM
>`----
>
>Ok, my kernel has been SMP, so I needed to look for SUSPEND_SMP first.
>In menuconfig I didn't find it in the suspect places.  So a grep told
>me:
>
>,----
>| root@hermes:/usr/src/linux-2.6.14-rc1# find . -name Kconfig | xargs
>| grep SUSPEND_SMP
>| ./drivers/acpi/Kconfig: depends on X86 && (!SMP || SUSPEND_SMP)
>| ./kernel/power/Kconfig:config SUSPEND_SMP
>`----
>
>Ok, looking int kernel/power/Kconfig:
>
>,----
>| config SUSPEND_SMP
>|         bool
>|         depends on HOTPLUG_CPU && X86 && PM
>`----
>
>I never imagined that I'd need HOTPLUG_CPU outside a virtualized
>environment ala LPAR or VM on S/390.
>
>Where the heck is HOTPLUG_CPU defined?
>
>,----
>| root@hermes:/usr/src/linux-2.6.14-rc1# find . -name Kconfig | xargs
>| grep HOTPLUG_CPU
>| ./arch/i386/Kconfig:config HOTPLUG_CPU
>| ./arch/ia64/Kconfig:config HOTPLUG_CPU
>| ./arch/parisc/Kconfig:config HOTPLUG_CPU
>`----
>
>And there it is:
>,----
>| config HOTPLUG_CPU
>|         bool "Support for hot-pluggable CPUs (EXPERIMENTAL)"
>|         depends on SMP && HOTPLUG && EXPERIMENTAL
>`----
>
>So, wouldn't it be far easier for a user to get all the needed symbols
>selected, instead of hunting dependencies in Kconfig?  For me it
>doesn't matter *what* options I need for ACPI_SLEEP.  I just want it
>enabled.
>
>I see that the dependency on EXPERIMENTAL might force us to have the
>user select three symbols to achive a single thing - but once
>HOTPLUG_CPU isn't experimental any more, we should try to make it
>easier for users.
>
>Jochen
>
>-- 
>#include <~/.signature>: permission denied
>


-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server.
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php

Re: wrong documentation for /proc/acpi/sleep?

[Jochen Hein]

"Brown, Len" <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> writes:

> Seems it is pretty obscure to enable SMP SLEEP in Kconfig.

Yes, it is ;-)

>>So, wouldn't it be far easier for a user to get all the needed symbols
>>selected, instead of hunting dependencies in Kconfig?  For me it
>>doesn't matter *what* options I need for ACPI_SLEEP.  I just want it
>>enabled.

On further thinking, why does Suspend-to-RAM need HOTPLUG_CPU, but
Suspend-to-Disk works without?  Might help in finding a better
solution.

Jochen

-- 
#include <~/.signature>: permission denied


-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. 
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php

RE: wrong documentation for /proc/acpi/sleep?

[Li, Shaohua]

Hi,
>
>"Brown, Len" <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> writes:
>
>> Seems it is pretty obscure to enable SMP SLEEP in Kconfig.
>
>Yes, it is ;-)
>
>>>So, wouldn't it be far easier for a user to get all the needed
symbols
>>>selected, instead of hunting dependencies in Kconfig?  For me it
>>>doesn't matter *what* options I need for ACPI_SLEEP.  I just want it
>>>enabled.
>
>On further thinking, why does Suspend-to-RAM need HOTPLUG_CPU, but
>Suspend-to-Disk works without?  Might help in finding a better
>solution.
STD also requires HOTPLUG_CPU. It might be the config error.

Thanks,
Shaohua


-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server.
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php