From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [Intel-gfx] [PATCH v2 5/5] ACPI: button: Obselete acpi_lid_open() invocations Date: Mon, 15 May 2017 12:41:30 +0300 Message-ID: <877f1imp85.fsf@intel.com> References: <2a779ae8c280c968b3237ac4a3d9580df7262a46.1493951798.git.lv.zheng@intel.com> <22b130fe0cf3fca19b0e14c69426fe36766cf2ee.1494311429.git.lv.zheng@intel.com> <1AE640813FDE7649BE1B193DEA596E886CEA2BB0@SHSMSX101.ccr.corp.intel.com> <1AE640813FDE7649BE1B193DEA596E886CEA2E0E@SHSMSX101.ccr.corp.intel.com> <1AE640813FDE7649BE1B193DEA596E886CEA38F0@SHSMSX101.ccr.corp.intel.com> <87a86emryv.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mga11.intel.com ([192.55.52.93]:4644 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760081AbdEOJjI (ORCPT ); Mon, 15 May 2017 05:39:08 -0400 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Benjamin Tissoires Cc: "Zheng, Lv" , "Brown, Len" , "nouveau@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "Wysocki, Rafael J" , "Rafael J . Wysocki" , Lv Zheng , ACPI Devel Maling List On Mon, 15 May 2017, Benjamin Tissoires wrote: > On Mon, May 15, 2017 at 10:42 AM, Jani Nikula > wrote: >> On Mon, 15 May 2017, Benjamin Tissoires wrote: >>> I'll answer everything in the other thread, where there are slightly >>> more other points raised: https://lkml.org/lkml/2017/5/15/10 >> >> If you are discussing changes impacting i915, please keep intel-gfx list >> in the loop. >> > > I can add intel-gfx to the other thread if you want, but this will IMO > just add more noise to your list. > The question is whether or not the kernel should provide a fake state > for the _LID acpi call, and until we reach an agreement on how to > handle things, there is no point changing the currently working code > in i915. Fair enough. > It is true that there is an issue in i915 regarding the fact that > intel_lid_notify() doesn't use the provided value but calls > acpi_lid_open(), but this is something that can be solved in > https://bugs.freedesktop.org/show_bug.cgi?id=100923, when the > situation clarifies. The snarky reply here might be that we're just following the documentation of acpi_lid_notifier_register(), acpi_lid_open(), and friends. ;) BR, Jani. -- Jani Nikula, Intel Open Source Technology Center